For #236: Added the rest of RtNetwork methods and fixed tests

[paulodamaso]

For #236:

• Added the code remaining to RtNetwork related too all other operations
• Fixed the tests, that were wrong; the actual tests check if we are making the correct request to docker API

[0crat]

Job #245 is now in scope, role is REV

[coveralls]

Pull Request Test Coverage Report for Build 433

• 29 of 29 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+1.6%) to 87.608%

---

Totals
Change from base Build 431:	1.6%
Covered Lines:	608
Relevant Lines:	694

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 445

• 33 of 33 (100.0%) changed or added relevant lines in 1 file are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+2.2%) to 88.131%

---

Files with Coverage Reduction	New Missed Lines	%
src/main/java/com/amihaiemil/docker/RtNetworks.java	2	93.94%

Totals
Change from base Build 431:	2.2%
Covered Lines:	646
Relevant Lines:	733

---

💛 - Coveralls

[0crat]

This pull request #245 is assigned to @bkuzmic/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[bkuzmic]

@paulodamaso Thanks for the PR. Please take a look at the comments

[bkuzmic]

@paulodamaso Please use JsonObject here instead of composing it with String.format. This will make the code reusable when adding more methods with optional parameters. For example, in the next step, new connect method can be added to support optional EndpointConfig parameter, like this: connect(final String containerId, final JsonObject endpointConfig)

[bkuzmic]

@paulodamaso See previous comment. Also use JsonObject instead.

[paulodamaso]

@bkuzmic Done, please take a look

[amihaiemil]

@rultor merge it

[rultor]

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge it

@amihaiemil @paulodamaso Oops, I failed. You can see the full log here (spent 3min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 15492
+ echo '1.68.1 24dc2a841'
1.68.1 24dc2a841
+ date
Thu Jan  3 13:13:03 CET 2019
+ uptime
 13:13:03 up 19 days,  3:43,  0 users,  load average: 6.59, 6.73, 6.72
+ ff=default
+ image=yegor256/java8
+ rebase=false
+ head_branch=master
+ pull_title='For #236: Added the rest of RtNetwork methods and fixed tests'
+ author=amihaiemil
+ directory=
+ head=git@github.com:amihaiemil/docker-java-api.git
+ pull_id=245
+ fork=git@github.com:paulodamaso/docker-java-api.git
+ fork_branch=236
+ squash=false
+ vars=('--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=head=git@github.com:amihaiemil/docker-java-api.git' '--env=pull_id=245' '--env=fork=git@github.com:paulodamaso/docker-java-api.git' '--env=fork_branch=236' '--env=head_branch=master' '--env=pull_title=For #236: Added the rest of RtNetwork methods and fixed tests' '--env=author=amihaiemil' '--env=scripts=( '\''export '\''\'\'''\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head=git@github.com:amihaiemil/docker-java-api.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=245'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:paulodamaso/docker-java-api.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=236'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=For #236: Added the rest of RtNetwork methods and fixed tests'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=amihaiemil'\''\'\'''\'''\'' '\'';'\'' '\''mvn clean install -Pcheckstyle'\'' '\'';'\'' )')
+ scripts=('export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''head=git@github.com:amihaiemil/docker-java-api.git'\''' ';' 'export '\''pull_id=245'\''' ';' 'export '\''fork=git@github.com:paulodamaso/docker-java-api.git'\''' ';' 'export '\''fork_branch=236'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=For #236: Added the rest of RtNetwork methods and fixed tests'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';')
+ container=amihaiemil_docker-java-api_245
+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:amihaiemil/docker-java-api.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''head=git@github.com:amihaiemil/docker-java-api.git'\''' ';' 'export '\''pull_id=245'\''' ';' 'export '\''fork=git@github.com:paulodamaso/docker-java-api.git'\''' ';' 'export '\''fork_branch=236'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=For #236: Added the rest of RtNetwork methods and fixed tests'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpgkeys: key 9AF0FA4C can't be retrieved
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver helper general error
gpg: keyserver communications error: unknown pubkey algorithm
gpg: keyserver receive failed: unknown pubkey algorithm
'cid' file is absent, container wasn't started correctly

[0crat]

Job was finished in 27 hours, bonus for fast delivery is possible (see §36)

[0crat]

Quality is low, no payment, see §31:

[0crat]

The job #245 is now out of scope

[0crat]

Job gh:amihaiemil/docker-java-api#245 doesn't exist in WBS, can't create order

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z