Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #243: Adding filters to FilteredUriBuilder #253

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

bkuzmic
Copy link
Contributor

@bkuzmic bkuzmic commented Jan 2, 2019

For #243:

  • implementing adding Json filters to FilteredUriBuilder

@0crat 0crat added the scope label Jan 2, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 2, 2019

Job #253 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Jan 2, 2019

This pull request #253 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@coveralls
Copy link

coveralls commented Jan 2, 2019

Pull Request Test Coverage Report for Build 446

  • 15 of 17 (88.24%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 86.969%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/FilteredUriBuilder.java 11 13 84.62%
Totals Coverage Status
Change from base Build 444: 0.4%
Covered Lines: 614
Relevant Lines: 706

💛 - Coveralls

Copy link
Contributor

@paulodamaso paulodamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkuzmic That's good, thanks

@paulodamaso
Copy link
Contributor

@rultor merge

@amihaiemil
Copy link
Owner

@rultor merge it

@amihaiemil amihaiemil merged commit c50b36c into amihaiemil:master Jan 3, 2019
@rultor
Copy link
Collaborator

rultor commented Jan 3, 2019

@rultor merge

@paulodamaso Thanks for your request. @amihaiemil Please confirm this.

@rultor
Copy link
Collaborator

rultor commented Jan 3, 2019

@rultor merge it

@amihaiemil @bkuzmic The pull request is closed already, so I can't merge it

@rultor
Copy link
Collaborator

rultor commented Jan 3, 2019

@rultor merge it

@amihaiemil I'm sorry, I don't understand you :( Check this page and try again please

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

Job was finished in 22 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat removed the scope label Jan 3, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

The job #253 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

Order was finished: +20 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants