Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eslint@8 support #489

Merged
merged 6 commits into from
Nov 15, 2021
Merged

feat: eslint@8 support #489

merged 6 commits into from
Nov 15, 2021

Conversation

amilajack
Copy link
Owner

@amilajack amilajack commented Oct 13, 2021

Fixes #488

@amilajack amilajack changed the title fix: add eslint@8 support eslint@8 support Oct 13, 2021
@amilajack amilajack changed the title eslint@8 support feat: eslint@8 support Oct 13, 2021
@scsinke
Copy link

scsinke commented Nov 9, 2021

@amilajack Is there any more work that needs to be done?

@quicoto
Copy link

quicoto commented Nov 12, 2021

Any update on this PR?

Thank you

@amilajack
Copy link
Owner Author

This will be out by the end of today

@quicoto
Copy link

quicoto commented Nov 15, 2021

@amilajack I would love to help to push this, but on the failed check I don't know what to look at. Are we missing something code-wise?

Thank you

@amilajack amilajack merged commit b1b9306 into master Nov 15, 2021
@amilajack amilajack deleted the feat/eslint-8 branch November 15, 2021 18:10
@amilajack
Copy link
Owner Author

@quicoto published to the next tag. Would be great if you or others could test this before I publish to latest

@quicoto
Copy link

quicoto commented Nov 16, 2021

@amilajack just tried the next tag, it worked. Feel free to publish.

Thank you

@amilajack
Copy link
Owner Author

Published to latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ESLint 8?
3 participants