Dhruv/defaulting style fixes #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhruv-deriv
requested review from
matin-deriv,
maryia-deriv and
amina-deriv
as code owners
amina-deriv
reviewed
Sep 21, 2024
| @@ -14,10 +14,9 @@ | |||
| &--pending { | |||
| color: var(--status-warning-dark); | |||
| background-color: var(--status-warning-transparent); | |||
| text-decoration: underline; | |||
There was a problem hiding this comment.
we need this styling in tradershub dashboard. i will fix it in my PR for now. will merge this now
amina-deriv
approved these changes
Sep 21, 2024
Dhruv-deriv
changed the title
|
can you update your PR with feature branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
1.fixed the padding of the badges
2.fixed the icon size of in review
3. fixed condition where if eg: POI is verified should have disabled arrow and POA is Failed should have Enabled arrow
Screenshots:
