Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to Angel PR #4564 #2

Open
wants to merge 2 commits into
base: openshift-resources
Choose a base branch
from
Open

Minor changes to Angel PR #4564 #2

wants to merge 2 commits into from

Conversation

l0rd
Copy link

@l0rd l0rd commented Mar 28, 2017

That PR should not be merged but just used as a reference to the modifications I did to make the PR work.

I'm adding the following env variables when starting che-server:

      spec:
        containers:
        - env:
          - name: JAVA_OPTS
            value: "-Xms256M -Xmx256M"
          - name: CHE_WORKSPACE_JAVA_OPTIONS
            value: "-Xms256m -Xmx512M -Djava.security.egd=file:/dev/./urandom"
          - name: CHE_WORKSPACE_MAVEN_OPTIONS
            value: "-Xms256m -Xmx512M -Djava.security.egd=file:/dev/./urandom"
          - name: CHE_WORKSPACE_AGENT_DEV_MAX__START__TIME__MS
            value: "360000"
          - name: CHE_WORKSPACE_DEFAULT__MEMORY__MB
            value: "512"

amisevsk and others added 2 commits March 27, 2017 02:23
@amisevsk
Add support for resource requests/limits when running on Openshift
0981bea 
Add resource requests and limits to workspace Pods when running on
OpenShift. Workspace memory limit is obtained from the che REST API,
while memory request, cpu limit, and cpu request are determined
by new che properties

- "che.openshift.workspace.memory.request"
- "che.openshift.workspace.cpu.limit"
- "che.openshift.workspace.cpu.request"

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@l0rd
Minor changes to Angel PR eclipse-che#4564
bcca8fd
@amisevsk amisevsk force-pushed the openshift-resources branch 3 times, most recently from 3b1e5f6 to 4d601c7 Compare March 29, 2017 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l0rd @amisevsk