Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prints tree to visualise #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prints tree to visualise #13

wants to merge 1 commit into from

Conversation

amishas157
Copy link
Owner

Resolves #7

An example following:

image

@daniel-j-h
Copy link
Collaborator

Awesome, this is beautiful! If you save SVGs you can handle larger trees and zoom in or out 🚀

(There are some issues with Travis, I think you need to adapt your code to latest master a bit)

@daniel-j-h
Copy link
Collaborator

Ah, what comes to mind: in the plot we see how you store strings in their original form.

What we probably want to do is compute the metric on normalized strings and user query, so that e.g. case-sensitivity doesn't matter, the strings are in unicode normal form, maybe even handling digits and words the same (think: 2nd street, second street), country-specific abbreviations, and language-specifics.

Just some food for thought, we don't have to implement all of those :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants