fixed 24-hour format not working for sunrise/sunset #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
It might be better to have a function which only converts any date/timestamp to the correct format selected by the user in the future. The code snippet I added can be found at multiple places within the source code (in different files), which makes it harder to change and maintain if something is changed (e.g. the settings class). Having it in just one function and then calling that with the date/timestamp as an input makes it easier and less prone to bugs like this.