Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub - User data retry logic update #64

Merged
merged 3 commits into from
Dec 28, 2021
Merged

GitHub - User data retry logic update #64

merged 3 commits into from
Dec 28, 2021

Conversation

amitsaha
Copy link
Owner

@amitsaha amitsaha commented Dec 28, 2021

This PR updates the retry added in fa5e695:

  • Introduce a new option for controlling the maximum number of retries: github.createUserMigrationRetryMax (an integer) which is by default set to 5. Together with github.createUserMigrationRetry (a boolean) which is set to true by default, these options will control the user migration creation behavior. This may be extrapolated to org migration as well.
  • Add test for user migration start using https://github.com/migueleliasweb/go-github-mock

The last change is will allow us to write bunch of tests for the GitHub operations and refactor things.

@amitsaha amitsaha merged commit 2c7432c into master Dec 28, 2021
@amitsaha amitsaha deleted the issue_62_retry branch December 28, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant