Fix Bug ignore private repo logic #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In line 48 if expression had a bug: private repos would be skipped if `ignorePrivate` is false.
|
@arborknot-ci thanks for the fix! Would you be able to add a test please? I have been trying to improve the code quality, and if we take these chances to at least add tests to start with, that would be progress. |
|
@amitsaha Hi, I'm sorry but I didn't quite understand the logic behind the tests you wrote nor I have the time to write one right now. |
|
No worries, thanks - the new release has been created, binaries should be available shortly at https://github.com/amitsaha/gitbackup/releases/tag/v0.8.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line 48 if expression had a bug: private repos would be skipped if
ignorePrivateis false.