Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome Shell 40 Port #20

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Gnome Shell 40 Port #20

merged 4 commits into from
Mar 26, 2021

Conversation

jrahmatzadeh
Copy link
Contributor

prefs.js

  • show_all() no longer needed on GTK4.
  • No need to use destroy for prefs widget in GTK4.
  • Connecting signal to the combo box directly in prefs.js.

prefs.ui

  • More detailed margin properties for GTK4.
  • No Packing in GTK4.
  • Remove handler to directly adding that in js file.
  • No needed can-focus because it is true by default in GTK4.

metadata.json

  • Removed "3.38" and "3.36" and added "40.0" to the shell version.
  • Bumped the version to 16.

@amivaleo
Copy link
Owner

I'm considering the possibility of transfer full ownership of this extension to you.
I planned to have fedora 34 installed on my pc before working on this.

Thank you, JustPy.

@amivaleo amivaleo merged commit 6e91fda into amivaleo:master Mar 26, 2021
@jrahmatzadeh
Copy link
Contributor Author

I'm just going through extensions and porting them to GNOME Shell 40. No need to transfer the ownership ;)

@amivaleo
Copy link
Owner

Anyway, I'm not adding this to EGO before I can test it. And I'm too lazy to set up a virtual machine. 👀️
I'll put my hands on this when I get fedora 34 on my laptop, which is going to happen in something like 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants