Merge pull request #2 from amiyzku/issue#1

Issue#1
amiyzku · Oct 25, 2023 · 04adc44 · 04adc44
2 parents 7b992f9 + d3e3cd0
commit 04adc44
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -12,8 +12,10 @@ A simple CLI tool to set the microphone volume to the maximum in MacOS.
 
 ```bash
 sudo mv max-mic-volume /usr/local/bin/
+sudo chmod 755 /usr/local/bin/max-mic-volume
 
-sudo curl -o /Library/LaunchDaemons/com.github.amiyzku.max-mic-volume.plist https://raw.githubusercontent.com/amiyzku/max-mic-volume/master/com.github.amiyzku.max-mic-volume.plist
-sudo chown root:wheel /Library/LaunchDaemons/com.github.amiyzku.max-mic-volume.plist
-sudo chmod 644 /Library/LaunchDaemons/com.github.amiyzku.max-mic-volume.plist
+sudo curl -o /Library/LaunchAgents/com.github.amiyzku.max-mic-volume.plist https://raw.githubusercontent.com/amiyzku/max-mic-volume/master/com.github.amiyzku.max-mic-volume.plist
+sudo chmod 644 /Library/LaunchAgents/com.github.amiyzku.max-mic-volume.plist
+
+launchctl load /Library/LaunchAgents/com.github.amiyzku.max-mic-volume.plist
 ```
diff --git a/src/mic_device.rs b/src/mic_device.rs
@@ -9,7 +9,7 @@ use std::ptr::null;
 
 use crate::volume::Volume;
 
-#[derive(Debug)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct MicDevice {
     device_id: u32,
 }

diff --git a/src/volume.rs b/src/volume.rs
@@ -1,4 +1,4 @@
-#[derive(Debug)]
+#[derive(Debug, PartialEq, PartialOrd)]
 pub struct Volume(f32);
 
 impl Volume {
@@ -20,12 +20,6 @@ impl Volume {
     }
 }
 
-impl PartialEq for Volume {
-    fn eq(&self, other: &Self) -> bool {
-        self.0 == other.0
-    }
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;