Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from mergeability:master #58

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Jul 4, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@restack-app
Copy link

restack-app bot commented Jul 4, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@vercel
Copy link

vercel bot commented Jul 4, 2023

@jonny7read is attempting to deploy a commit to the Ammar Team on Vercel.

A member of the Team first needs to authorize it.

@instapr
Copy link

instapr bot commented Jul 4, 2023

The pull request looks good overall. There's just one minor suggestion:

In the future, please provide a more detailed description of the changes made in the pull request body. This will make it easier for reviewers to understand the purpose and impact of the changes.

@pr-explainer-bot
Copy link

Pull Request Report

Greetings! 👋

Thank you for your contribution to this project! Here's a report summarizing the changes made in the pull request:

Changes

  1. Fixed syntax, link, and grammar in deployment.rst ✅ (docs: Fix syntax, link and grammar in deployment.rst mergeability/mergeable#722)
  2. Updated link syntax for the style guide in CONTRIBUTING.md ✅ (docs: Update CONTRIBUTING.md link syntax for style guide mergeability/mergeable#723)

Suggestions to Improve Code

No suggestions provided. Moving on...

Bugs

No bugs reported. Great job!

Improvements

No improvements mentioned. Let's continue...

Rating

Code Rating: 8/10

Criteria:

  • Readability: The code is easy to understand and follow.
  • Performance: The code performs well and doesn't have any noticeable performance issues.
  • Security: The code appears to be secure and doesn't have any obvious security vulnerabilities.

Keep up the good work! If you have any further contributions, feel free to submit them. Happy coding! 🎉

@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pull pull bot added the ⤵️ pull label Jul 4, 2023
@ammar-ahmed-butt ammar-ahmed-butt merged commit cbb01da into ammar-knowledge:master Jul 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants