Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from TomerFi:main #76

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 7, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by CodeRabbit

  • Chores
    • Updated the version of the version-bumping action used in the release workflow, potentially enhancing the versioning process.
  • New Features
    • Transitioned to ES module syntax for improved clarity and compatibility across various files, including handlers.
    • Updated the mkdocs package to the latest version (1.6.1) and the mkdocs-material package to the latest version (9.5.33), potentially introducing bug fixes and performance improvements.

Bumps [probot](https://github.com/probot/probot) from 13.3.6 to 13.3.7.
- [Release notes](https://github.com/probot/probot/releases)
- [Commits](probot/probot@v13.3.6...v13.3.7)

---
updated-dependencies:
- dependency-name: probot
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link

semanticdiff-com bot commented Aug 7, 2024

Review changes with SemanticDiff.

Analyzed 17 of 23 files.

Overall, the semantic diff is 43% smaller than the GitHub diff.

File Information
Filename Status
✔️ eslint.config.mjs Analyzed
mkdocs.yml Unsupported file format
package-lock.json Unsupported file format
✔️ package.json 61.35% smaller
requirements.txt Unsupported file format
✔️ tests/auto-me-bot.test.js 9.57% smaller
✔️ tests/handlers/pr-auto-approve.test.js 30.21% smaller
✔️ tests/handlers/pr-conventional-commits.test.js 16.22% smaller
✔️ tests/handlers/pr-conventional-title.test.js 18.7% smaller
✔️ tests/handlers/pr-lifecycle-labels.test.js 37.3% smaller
✔️ tests/handlers/pr-signed-commits.test.js 21.13% smaller
✔️ tests/handlers/pr-tasks-list.test.js 27.69% smaller
✔️ src/app-runner.js 27.41% smaller
✔️ src/auto-me-bot.js 11.29% smaller
✔️ src/handlers/pr-auto-approve.js 62.81% smaller
✔️ src/handlers/pr-conventional-commits.js 9.73% smaller
✔️ src/handlers/pr-conventional-title.js 9.73% smaller
✔️ src/handlers/pr-lifecycle-labels.js 4.68% smaller
✔️ src/handlers/pr-signed-commits.js 79.69% smaller
✔️ src/handlers/pr-tasks-list.js 23.76% smaller
.github/workflows/pages.yml Unsupported file format
.github/workflows/release.yml Unsupported file format
.github/workflows/stage.yml Unsupported file format

Copy link

restack-app bot commented Aug 7, 2024

No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews.

Copy link

pr-code-reviewer bot commented Aug 7, 2024

👋 Hi there!

  1. Update setup-python action to version v5.2.0 in .github/workflows/pages.yml.
  2. Upgrade version-bumper-action to version 2.0.3 in .github/workflows/release.yml.
  3. Include package.json and package-lock.json in the zip command in .github/workflows/release.yml.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

Copy link

coderabbitai bot commented Aug 7, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

A series of updates were made to the codebase, primarily transitioning from CommonJS to ES module syntax for improved clarity and maintainability. The requirements.txt file was modified to update the mkdocs package version to 1.6.1 and the mkdocs-material package version to 9.5.33. Additionally, minor updates in the GitHub Actions workflows were implemented to reflect changes in the versioning process for both Python setup and version bumping.

Changes

Files Change Summary
.github/workflows/release.yml Updated version-bumper-action from 2.0.2 to 2.0.3.
.github/workflows/pages.yml, .github/workflows/stage.yml Updated actions/setup-python from v5.1.1 to v5.2.0.
requirements.txt Updated mkdocs package version from 1.6.0 to 1.6.1 and mkdocs-material from 9.5.31 to 9.5.33.
src/*.js (app-runner.js, handlers/*.js) Transitioned from CommonJS to ES module syntax; updated imports and exports for consistency.

Poem

In the code where bunnies play,
A version bump has come our way!
With modern modules hopping in,
Our code grows strong, let’s begin!
Fluffy changes, clear and bright,
Together we code, what a delight! 🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

instapr bot commented Aug 7, 2024

Please add a more descriptive and concise title to your pull request so that reviewers can quickly understand the changes being made.

@pull pull bot added the ⤵️ pull label Aug 7, 2024
Bumps [marked](https://github.com/markedjs/marked) from 13.0.3 to 14.0.0.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v13.0.3...v14.0.0)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mocha](https://github.com/mochajs/mocha) from 10.7.0 to 10.7.3.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md)
- [Commits](mochajs/mocha@v10.7.0...v10.7.3)

---
updated-dependencies:
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tomerfi/version-bumper-action](https://github.com/tomerfi/version-bumper-action) from 2.0.2 to 2.0.3.
- [Release notes](https://github.com/tomerfi/version-bumper-action/releases)
- [Commits](TomerFi/version-bumper-action@2.0.2...2.0.3)

---
updated-dependencies:
- dependency-name: tomerfi/version-bumper-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b4bdc9c and 6a57191.

Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json, !**/*.json
  • package.json is excluded by !**/*.json
Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/release.yml

TomerFi and others added 3 commits August 12, 2024 18:13
* ci: bump commitlint components to es version

Signed-off-by: Tomer Figenblat <tomer@tomfi.info>

* chore: change package type to es module

BREAKING CHANGE: package type is not an es module instead of commonjs

Signed-off-by: Tomer Figenblat <tomer@tomfi.info>

---------

Signed-off-by: Tomer Figenblat <tomer@tomfi.info>
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.8.0 to 9.9.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/commits/v9.9.0/packages/js)

---
updated-dependencies:
- dependency-name: "@eslint/js"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 9.8.0 to 9.9.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.8.0...v9.9.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Outside diff range, codebase verification and nitpick comments (6)
src/handlers/pr-auto-approve.js (2)

9-12: Use concise property shorthand in object literals.

When exporting an object with properties that have the same name as the variables, you can use shorthand syntax.

-export default {
-    match: match,
-    run: run
-}
+export default {
+    match,
+    run
+}

Line range hint 22-58:
Consider error handling improvements in run function.

The run function handles errors using catch. Consider adding more specific error messages or logging additional context to improve debugging.

-  console.error(error);
+  console.error('Error approving PR:', error);
src/auto-me-bot.js (1)

Line range hint 60-94:
Consider simplifying asynchronous logic in handlersController.

The handlersController function uses Promise.allSettled. Consider using Promise.all if you need to fail fast on any rejection, or ensure proper handling of settled promises.

-  if (invocations) {
-      await Promise.allSettled(invocations);
-  }
+  if (invocations.length > 0) {
+      await Promise.all(invocations);
+  }
src/handlers/pr-conventional-title.js (2)

14-17: Use concise property shorthand in object literals.

When exporting an object with properties that have the same name as the variables, you can use shorthand syntax.

-export default {
-    match: match,
-    run: run
-}
+export default {
+    match,
+    run
+}

Line range hint 27-63:
Consider error handling improvements in run function.

The run function handles errors using catch. Consider adding more specific error messages or logging additional context to improve debugging.

-  console.error(error);
+  console.error('Error verifying PR title:', error);
src/handlers/pr-conventional-commits.js (1)

Line range hint 27-87:
Optimize Promise Handling in the run Function.

The run function uses a mix of await and .then()/.catch() for promise handling. Consider using async/await consistently for improved readability and error handling.

- await context.octokit.rest.pulls.listCommits(context.pullRequest())
-     .then(response => {
-         if (response.status === 200) {
-             commitObjs = response.data;
-         } else {
-             let {status, message} = response;
-             console.error({status,  message});
-         }
-     })
-     .catch(error => console.error(error));
+ try {
+     const response = await context.octokit.rest.pulls.listCommits(context.pullRequest());
+     if (response.status === 200) {
+         commitObjs = response.data;
+     } else {
+         console.error({ status: response.status, message: response.message });
+     }
+ } catch (error) {
+     console.error(error);
+ }
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6a57191 and 4cce054.

Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json, !**/*.json
  • package.json is excluded by !**/*.json
Files selected for processing (16)
  • eslint.config.mjs (1 hunks)
  • src/app-runner.js (1 hunks)
  • src/auto-me-bot.js (2 hunks)
  • src/handlers/pr-auto-approve.js (1 hunks)
  • src/handlers/pr-conventional-commits.js (2 hunks)
  • src/handlers/pr-conventional-title.js (2 hunks)
  • src/handlers/pr-lifecycle-labels.js (3 hunks)
  • src/handlers/pr-signed-commits.js (3 hunks)
  • src/handlers/pr-tasks-list.js (2 hunks)
  • tests/auto-me-bot.test.js (3 hunks)
  • tests/handlers/pr-auto-approve.test.js (1 hunks)
  • tests/handlers/pr-conventional-commits.test.js (4 hunks)
  • tests/handlers/pr-conventional-title.test.js (4 hunks)
  • tests/handlers/pr-lifecycle-labels.test.js (1 hunks)
  • tests/handlers/pr-signed-commits.test.js (10 hunks)
  • tests/handlers/pr-tasks-list.test.js (1 hunks)
Files skipped from review due to trivial changes (1)
  • tests/handlers/pr-tasks-list.test.js
Additional comments not posted (31)
eslint.config.mjs (2)

10-10: Transition to ES module syntax is appropriate.

The change from sourceType: "script" to sourceType: "module" aligns with the transition to ES module syntax, enhancing compatibility with modern JavaScript standards.


12-12: Verify the usage of globals.nodeBuiltin.

Ensure that globals.nodeBuiltin provides the necessary global variables for your Node.js environment.

src/app-runner.js (2)

1-2: Transition to ES module syntax is appropriate.

The use of import statements instead of require aligns with modern JavaScript standards and improves module compatibility.


6-6: Ensure correct usage of handler function.

The export of handler as an ES module function is correct. Ensure that all references to handler in your codebase are updated to match this new syntax.

src/handlers/pr-tasks-list.js (4)

1-2: Transition to ES module syntax is appropriate.

The use of import statements for marked and EOL aligns with modern JavaScript standards, enhancing compatibility.


7-10: Export structure is clear and concise.

The new export structure using export default improves clarity and aligns with ES module conventions.


Line range hint 13-23:
Ensure correct usage of match function.

The match function is now part of the exported object. Verify that all references to match in your codebase are updated accordingly.

Verification successful

All references to the match function are correctly updated.

The match function is consistently used as part of exported objects in the handler files, and the test files reference it appropriately for testing purposes. No further updates are needed.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all references to `match` are updated to use the new export structure.

# Test: Search for references to `match` in the codebase.
rg --type js 'match' -A 5

Length of output: 32021


Line range hint 25-54:
Ensure correct usage of run function.

The run function is now part of the exported object. Verify that all references to run in your codebase are updated accordingly.

Verification successful

Verification Successful: Correct Usage of run Function

The run function in src/handlers/pr-tasks-list.js is correctly exported and used in the codebase. The references to run in other files, such as src/auto-me-bot.js, are consistent with the expected usage of handler specifications. No further updates are necessary.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all references to `run` are updated to use the new export structure.

# Test: Search for references to `run` in the codebase.
rg --type js 'run' -A 5

Length of output: 59039

src/handlers/pr-auto-approve.js (1)

15-20: Ensure event matching logic is robust.

The match function checks if the event is a pull request and if the action is in the specified list. Ensure that context.payload always contains the expected structure to avoid potential errors.

src/auto-me-bot.js (2)

1-9: Ensure ES module import paths include file extensions.

The import statements correctly include .js extensions, which is necessary for ES modules. Ensure all paths are accurate and files exist.


55-57: Ensure compatibility with Probot and ES module syntax.

The main function is now exported as export default. Verify that the Probot framework is compatible with this syntax in your deployment environment.

src/handlers/pr-conventional-title.js (1)

20-25: Ensure event matching logic is robust.

The match function checks if the event is a pull request and if the action is in the specified list. Ensure that context.payload always contains the expected structure to avoid potential errors.

src/handlers/pr-conventional-commits.js (2)

1-3: Transition to ES Module Syntax for Imports.

The change from require to import statements aligns with modern JavaScript practices, enhancing compatibility and maintainability. Ensure that the rest of the codebase is compatible with ES module syntax.


20-25: Ensure Event and Action Matching Logic is Correct.

The match function checks for specific events and actions. Verify that the context payload structure is consistent across all usages to prevent runtime errors.

Verification successful

Consistent Payload Structure for match Function

The match function is used across multiple test files and handlers, consistently expecting a context object with a payload property that includes pull_request and action. The tests verify various scenarios, ensuring that the function behaves correctly with both known and unknown event types and actions. This indicates that the payload structure is consistently handled in the codebase.

  • Test Files:

    • tests/handlers/pr-tasks-list.test.js
    • tests/handlers/pr-signed-commits.test.js
    • tests/handlers/pr-lifecycle-labels.test.js
    • tests/handlers/pr-conventional-title.test.js
    • tests/handlers/pr-conventional-commits.test.js
    • tests/handlers/pr-auto-approve.test.js
  • Handler Files:

    • src/handlers/pr-tasks-list.js
    • src/handlers/pr-signed-commits.js
    • src/handlers/pr-lifecycle-labels.js
    • src/handlers/pr-conventional-title.js
    • src/handlers/pr-conventional-commits.js
    • src/handlers/pr-auto-approve.js

The tests and handlers consistently use the expected payload structure, suggesting that runtime errors due to payload inconsistencies are unlikely.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the `match` function to ensure consistent payload structure.

# Test: Search for all occurrences of the match function. Expect: Consistent payload structure.
rg --type javascript -A 5 'match\('

Length of output: 72


Script:

#!/bin/bash
# Find all JavaScript files and search for the usage of the `match` function to ensure consistent payload structure.
fd -e js -e jsx -e ts -e tsx | xargs rg -A 5 'match\('

Length of output: 23582

src/handlers/pr-signed-commits.js (2)

1-2: Transition to ES Module Syntax for Imports.

The change from require to import statements aligns with modern JavaScript practices, enhancing compatibility and maintainability. Ensure that the rest of the codebase is compatible with ES module syntax.


28-87: Clarify the Purpose of runWrapper.

The runWrapper function is used to inject emailOpts. Ensure that this pattern is consistently applied across the codebase and consider renaming for clarity.

tests/handlers/pr-conventional-title.test.js (2)

1-5: Transition to ES Module Syntax for Imports.

The change from require to import statements aligns with modern JavaScript practices, enhancing compatibility and maintainability. Ensure that the rest of the test suite is compatible with ES module syntax.


9-9: Ensure Compatibility with Direct Imports.

The transition from rewire to direct imports simplifies the testing setup. Verify that the sut module is correctly initialized and does not rely on any state that rewire previously managed.

Verification successful

Direct Import of sut Module is Correctly Initialized

The sut module is used directly in multiple test cases without any indication of reliance on rewire. The transition to direct imports appears to be functioning correctly.

  • Usage of sut is consistent across test files such as pr-tasks-list.test.js, pr-signed-commits.test.js, pr-lifecycle-labels.test.js, pr-conventional-title.test.js, pr-conventional-commits.test.js, and pr-auto-approve.test.js.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the initialization of the `sut` module in tests.

# Test: Search for all occurrences of the sut module usage. Expect: Correct initialization without rewire.
rg --type javascript -A 5 'sut\.'

Length of output: 70


Script:

#!/bin/bash
# Corrected: Verify the initialization of the `sut` module in tests.

# Test: Search for all occurrences of the sut module usage. Expect: Correct initialization without rewire.
rg 'sut\.' --glob '*.js' -A 5

Length of output: 25652

src/handlers/pr-lifecycle-labels.js (4)

1-1: Transition to ES module syntax for imports.

The require statement has been correctly replaced with an import statement, aligning with modern JavaScript practices.


28-31: Use of named exports in ES module syntax.

The transition to named exports is correctly implemented. This change enhances modularity and clarity.


Line range hint 34-51:
Ensure function match is correctly integrated.

The function match is now a standalone function and is correctly exported. Verify its usage across the codebase to ensure compatibility with the new export style.

Verification successful

Function match is correctly integrated and tested.

The match function in src/handlers/pr-lifecycle-labels.js is used and tested across multiple files, indicating proper integration. Each handler file appears to have its own match function, which is consistent with the modular design. The function is also being tested in various test files, confirming its usage.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the `match` function across the codebase.

# Test: Search for the function usage. Expect: Only occurrences of the new export style.
rg --type js 'match('

Length of output: 86


Script:

#!/bin/bash
# Description: Verify the usage of the `match` function across the codebase.

# Corrected Test: Search for the function usage. Expect: Only occurrences of the new export style.
rg --type js 'match\('

Length of output: 7159


Line range hint 53-91:
Ensure function run is correctly integrated.

The function run is now a standalone function and is correctly exported. Verify its usage across the codebase to ensure compatibility with the new export style.

tests/handlers/pr-auto-approve.test.js (2)

1-4: Transition to ES module syntax for imports.

The require statements have been correctly replaced with import statements, aligning with modern JavaScript practices.


8-8: Direct import of sut improves modularity.

The direct import of sut from pr-auto-approve.js simplifies the test setup and enhances maintainability.

tests/auto-me-bot.test.js (2)

1-4: Transition to ES module syntax for imports.

The require statements have been correctly replaced with import statements, aligning with modern JavaScript practices.


8-15: Direct imports improve modularity and clarity.

The direct imports of handlers and the handlersController enhance the clarity and maintainability of the test setup.

tests/handlers/pr-conventional-commits.test.js (2)

1-5: Transition to ES module syntax.

The import statements have been updated to use ES module syntax, which aligns with modern JavaScript practices. This change enhances readability and maintainability.


9-9: Direct import of sut improves dependency management.

Replacing rewire with a direct import simplifies the code and improves dependency management. Ensure that all necessary configurations are still accessible.

Verification successful

Direct import of sut is correctly implemented.

The transition from rewire to direct imports for sut has been successfully implemented across the codebase, enhancing dependency management without any apparent issues. Ensure that any configurations previously accessed through rewire are still accessible via the new import method.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the `sut` module is correctly imported and used.

# Test: Search for `sut` usage. Expect: Correct usage without rewire.
rg --type js 'sut' -A 5

Length of output: 30432

tests/handlers/pr-signed-commits.test.js (2)

1-6: Transition to ES module syntax and introduction of runWrapper.

The import statements have been updated, and the runWrapper function is introduced to encapsulate email validation options, enhancing test flexibility.


10-10: Verify the impact of removing verifyEmailStub.

The removal of verifyEmailStub may affect test coverage. Ensure that the runWrapper adequately replaces its functionality.

tests/handlers/pr-lifecycle-labels.test.js (1)

1-8: Transition to ES module syntax.

The import statements have been updated to use ES module syntax, improving readability and maintainability.

Comment on lines 14 to 17
export default {
match: match,
run: run
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Named Exports for Better Tree Shaking.

While using a default export is acceptable, consider using named exports for match and run to enable better tree shaking in bundlers.

- export default {
-     match: match,
-     run: run
- }
+ export { match, run }
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
export default {
match: match,
run: run
}
export { match, run }

Comment on lines +120 to +154
async function verifyCommitTrailer(commit, config, emailOpts) {
// list all 'Signed-off-by' trailers matching the author or committer
let trailerMatches = []
// skip commits for bots and ignored
if(shouldSkipCommit(commit, config)){
return;
}
// iterate over all lines in the commit message
commit.message.split(EOL).forEach(line => {
let match = line.match(SIGN_OFF_TRAILER_REGEX);
// only run for line matching the sign_off_by trailer
if (match !== null) {
let signed = { name: match[1], email: `${match[2]}@${match[3]}` };
// only list 'Signed-off-by' trailers matches if signed by author or commiter
if ((signed.name === commit.author.name && signed.email === commit.author.email) // signed by author
|| (signed.name === commit.committer.name && signed.email === commit.committer.email) // signed by committer
) {
trailerMatches.push(signed);
}
}
});
// reject if none found
// reject if no 'Signed-off-by' trailer signed by author or commiter found
if (trailerMatches.length === 0) {
return Promise.reject();
}
// verify all 'Signed-off-by' are legit emails
return Promise.all(trailerMatches.map(match =>
emailVerifier.verify(match.email, (err, info) => {
if (err || info.code !== emailVerifier.verifyCodes.finishedVerification) {
return Promise.reject();
// verify all 'Signed-off-by' trailers are legit emails
return Promise.all(trailerMatches.map(async tm => {
try {
let v = await validate({...emailOpts, email: tm.email, sender: tm.email})
if (v.valid) {
return Promise.resolve()
}
})));
} catch (e) {} // eslint-disable-line no-unused-vars, no-empty
return Promise.reject()
}))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Error Handling in verifyCommitTrailer.

The verifyCommitTrailer function uses Promise.reject() without providing error details. Consider including error messages for better debugging.

- return Promise.reject();
+ return Promise.reject(new Error('No valid Signed-off-by trailer found.'));
- return Promise.reject()
+ return Promise.reject(new Error('Invalid email in Signed-off-by trailer.'));

Comment on lines 15 to 18
export default {
match: match,
run: runWrapper({})
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Named Exports for Better Tree Shaking.

While using a default export is acceptable, consider using named exports for match and runWrapper to enable better tree shaking in bundlers.

- export default {
-     match: match,
-     run: runWrapper({})
- }
+ export { match, runWrapper }

Committable suggestion was skipped due to low confidence.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4cce054 and 41276a0.

Files ignored due to path filters (3)
  • mkdocs.yml is excluded by !**/*.yml
  • package-lock.json is excluded by !**/package-lock.json, !**/*.json
  • package.json is excluded by !**/*.json
Files selected for processing (1)
  • .github/workflows/release.yml (2 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/release.yml

TomerFi and others added 7 commits August 13, 2024 21:25
Signed-off-by: Tomer Figenblat <tomer@tomfi.info>
Signed-off-by: Tomer Figenblat <tomer@tomfi.info>
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.31 to 9.5.32.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.31...9.5.32)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (2)
src/handlers/pr-signed-commits.js (2)

28-35: Add error handling for check run creation in pr-signed-commits.js.

The current implementation of context.octokit.checks.create in src/handlers/pr-signed-commits.js lacks error handling. It's important to handle potential errors to ensure the application can gracefully manage failures during check run creation.

  • File: src/handlers/pr-signed-commits.js
  • Lines: 28-35

Consider adding try-catch blocks or promise rejection handling to manage errors effectively.

Analysis chain

Ensure proper error handling for check run creation.

Consider handling potential errors when creating the check run with context.octokit.checks.create.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify error handling for check run creation.

# Test: Search for error handling in check run creation. Expect: Proper error handling mechanism.
rg --type js 'context.octokit.checks.create'

Length of output: 1776


117-151: Improve error handling in verifyCommitTrailer.

The function currently has an empty catch block, which silently ignores errors during email validation. Consider adding detailed error messages or logging to provide better insight into any issues that arise during execution.

  • Lines 144-150: Enhance the catch block to include error logging or messages to improve traceability and debugging.
Analysis chain

Verify implementation of error handling improvements.

Ensure the function's error handling improvements align with previous suggestions.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify implementation of error handling improvements in `verifyCommitTrailer`.

# Test: Search for error handling in `verifyCommitTrailer`. Expect: Improved error handling with detailed error messages.
rg --type js 'verifyCommitTrailer'

Length of output: 286


Script:

#!/bin/bash
# Description: Search for error handling patterns in the `verifyCommitTrailer` function.

# Test: Search for try-catch blocks and comments related to error handling within the function.
rg --type js -A 10 'async function verifyCommitTrailer' | rg 'try|catch|error|reject|resolve|Promise'

Length of output: 103


Script:

#!/bin/bash
# Description: Extract the complete implementation of `verifyCommitTrailer` for manual inspection.

# Extract the entire function `verifyCommitTrailer` from the file for review.
ast-grep --lang javascript --pattern 'async function verifyCommitTrailer($_, $_, $_) { $$$ }'

Length of output: 3050

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 41276a0 and 8a37f1c.

Files ignored due to path filters (3)
  • mkdocs.yml is excluded by !**/*.yml
  • package-lock.json is excluded by !**/package-lock.json, !**/*.json
  • package.json is excluded by !**/*.json
Files selected for processing (8)
  • requirements.txt (1 hunks)
  • src/app-runner.js (1 hunks)
  • src/handlers/pr-auto-approve.js (1 hunks)
  • src/handlers/pr-conventional-commits.js (2 hunks)
  • src/handlers/pr-conventional-title.js (2 hunks)
  • src/handlers/pr-lifecycle-labels.js (3 hunks)
  • src/handlers/pr-signed-commits.js (3 hunks)
  • src/handlers/pr-tasks-list.js (2 hunks)
Files skipped from review due to trivial changes (2)
  • requirements.txt
  • src/app-runner.js
Files skipped from review as they are similar to previous changes (5)
  • src/handlers/pr-auto-approve.js
  • src/handlers/pr-conventional-commits.js
  • src/handlers/pr-conventional-title.js
  • src/handlers/pr-lifecycle-labels.js
  • src/handlers/pr-tasks-list.js
Additional comments not posted (6)
src/handlers/pr-signed-commits.js (6)

18-23: LGTM!

The match function correctly identifies relevant pull request events and actions.


24-25: LGTM!

The runWrapper function correctly wraps the run function to inject email verification options.


56-74: LGTM! Verify edge case handling for commit processing.

The logic for processing commits and checking for unsigned commits is correct. Ensure all edge cases are handled.


Line range hint 93-115: LGTM!

The shouldSkipCommit function correctly implements logic to skip certain commits based on configuration.


1-2: Verify compatibility of deep-email-validator.

Ensure that the deep-email-validator library is compatible with the existing code and provides the necessary functionality for email validation.


46-55: Clarify the necessity of rest in octokit.rest.pulls.listCommits.

The comment questions the need for rest. Ensure that this is necessary for the correct functioning of the API call.

Verification successful

The use of rest in octokit.rest.pulls.listCommits is necessary.

The rest property is part of the Octokit client structure, which organizes API methods under specific namespaces, such as rest, to access REST API endpoints. This usage is consistent with the Octokit client setup in this codebase.

  • src/handlers/pr-signed-commits.js: Line 46
  • src/handlers/pr-conventional-commits.js: Line 46
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the necessity of `rest` in `octokit.rest.pulls.listCommits`.

# Test: Search for the usage of `octokit.rest.pulls.listCommits`. Expect: Correct usage of the API.
rg --type js 'octokit.rest.pulls.listCommits'

Length of output: 629


Script:

#!/bin/bash
# Description: Verify the structure of the Octokit client to determine if `rest` is necessary.

# Test: Search for the initialization or import of `octokit` to understand its structure.
rg --type js 'octokit' -A 5

Length of output: 20675

Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.32 to 9.5.33.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.32...9.5.33)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8a37f1c and dccf2b6.

Files selected for processing (1)
  • requirements.txt (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • requirements.txt

Bumps [eslint](https://github.com/eslint/eslint) from 9.9.0 to 9.9.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.9.0...v9.9.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….1 (#501)

Bumps [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/config-conventional) from 19.2.2 to 19.4.1.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/config-conventional/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.4.1/@commitlint/config-conventional)

---
updated-dependencies:
- dependency-name: "@commitlint/config-conventional"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@commitlint/lint](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/lint) from 19.2.2 to 19.4.1.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/lint/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.4.1/@commitlint/lint)

---
updated-dependencies:
- dependency-name: "@commitlint/lint"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5.1.1...v5.2.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dccf2b6 and f221ef7.

Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json, !**/*.json
  • package.json is excluded by !**/*.json
Files selected for processing (2)
  • .github/workflows/pages.yml (1 hunks)
  • .github/workflows/stage.yml (1 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/pages.yml
  • .github/workflows/stage.yml

Bumps [mkdocs](https://github.com/mkdocs/mkdocs) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/mkdocs/mkdocs/releases)
- [Commits](mkdocs/mkdocs@1.6.0...1.6.1)

---
updated-dependencies:
- dependency-name: mkdocs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f221ef7 and 804dba8.

Files selected for processing (1)
  • requirements.txt (1 hunks)
Files skipped from review due to trivial changes (1)
  • requirements.txt

Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.33 to 9.5.34.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.33...9.5.34)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [marked](https://github.com/markedjs/marked) from 14.1.0 to 14.1.1.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v14.1.0...v14.1.1)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.9.1 to 9.10.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/commits/v9.10.0/packages/js)

---
updated-dependencies:
- dependency-name: "@eslint/js"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [marked](https://github.com/markedjs/marked) from 14.1.1 to 14.1.2.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v14.1.1...v14.1.2)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 9.9.1 to 9.10.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.9.1...v9.10.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@commitlint/lint](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/lint) from 19.4.1 to 19.5.0.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/lint/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.5.0/@commitlint/lint)

---
updated-dependencies:
- dependency-name: "@commitlint/lint"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [sinon](https://github.com/sinonjs/sinon) from 18.0.0 to 18.0.1.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md)
- [Commits](sinonjs/sinon@v18.0.0...v18.0.1)

---
updated-dependencies:
- dependency-name: sinon
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [serve-static](https://github.com/expressjs/serve-static) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `serve-static` from 1.15.0 to 1.16.2
- [Release notes](https://github.com/expressjs/serve-static/releases)
- [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md)
- [Commits](expressjs/serve-static@v1.15.0...v1.16.2)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: serve-static
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@commitlint/load](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/load) from 19.4.0 to 19.5.0.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/load/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.5.0/@commitlint/load)

---
updated-dependencies:
- dependency-name: "@commitlint/load"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….0 (#509)

Bumps [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/config-conventional) from 19.4.1 to 19.5.0.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/config-conventional/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.5.0/@commitlint/config-conventional)

---
updated-dependencies:
- dependency-name: "@commitlint/config-conventional"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [sinon](https://github.com/sinonjs/sinon) from 18.0.1 to 19.0.2.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md)
- [Commits](sinonjs/sinon@v18.0.1...v19.0.2)

---
updated-dependencies:
- dependency-name: sinon
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.34 to 9.5.35.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.34...9.5.35)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [probot](https://github.com/probot/probot) from 13.3.7 to 13.3.8.
- [Release notes](https://github.com/probot/probot/releases)
- [Commits](probot/probot@v13.3.7...v13.3.8)

---
updated-dependencies:
- dependency-name: probot
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.10.0 to 9.11.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/commits/v9.11.0/packages/js)

---
updated-dependencies:
- dependency-name: "@eslint/js"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.35 to 9.5.36.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.35...9.5.36)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 9.10.0 to 9.11.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.10.0...v9.11.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.36 to 9.5.38.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.36...9.5.38)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.38 to 9.5.39.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.38...9.5.39)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [globals](https://github.com/sindresorhus/globals) from 15.9.0 to 15.10.0.
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](sindresorhus/globals@v15.9.0...v15.10.0)

---
updated-dependencies:
- dependency-name: globals
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.11.1 to 9.12.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/commits/v9.12.0/packages/js)

---
updated-dependencies:
- dependency-name: "@eslint/js"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 9.11.1 to 9.12.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.11.1...v9.12.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [globals](https://github.com/sindresorhus/globals) from 15.10.0 to 15.11.0.
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](sindresorhus/globals@v15.10.0...v15.11.0)

---
updated-dependencies:
- dependency-name: globals
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.39 to 9.5.40.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.39...9.5.40)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant