Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added conversion using the system locale #453

Merged
merged 2 commits into from
Jan 11, 2024
Merged

added conversion using the system locale #453

merged 2 commits into from
Jan 11, 2024

Conversation

Nethius
Copy link
Collaborator

@Nethius Nethius commented Dec 5, 2023

No description provided.

@Nethius Nethius marked this pull request as draft December 5, 2023 02:40
@useribs
Copy link
Contributor

useribs commented Dec 5, 2023

Googling revealed there is utf8 method. isn't it a more versatile option? https://doc.qt.io/qt-6/qstring.html#toUtf8

@Nethius
Copy link
Collaborator Author

Nethius commented Dec 6, 2023

Googling revealed there is utf8 method. isn't it a more versatile option? https://doc.qt.io/qt-6/qstring.html#toUtf8

I tried toUtf8(), but when using this method, the application keeps crashing

@pokamest pokamest marked this pull request as ready for review December 12, 2023 13:19
Noxius87
Noxius87 suggested changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@Noxius87 Noxius87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a problem. On MacOS Catalina 10.15 containers are not connected after installation

@Nethius Nethius force-pushed the bugfix/windows-crush-on-utf8-symbolos branch from 622526b to 67f29ac Compare December 26, 2023 06:36
Noxius87
Noxius87 suggested changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@Noxius87 Noxius87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWG protocol does not connect after installation, when trying to install another protocol the application crashes on Windows 11

@pokamest pokamest merged commit 50ea4d3 into dev Jan 11, 2024
5 checks passed
@pokamest pokamest deleted the bugfix/windows-crush-on-utf8-symbolos branch January 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noxius87 Noxius87 Noxius87 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nethius @useribs @Noxius87 @pokamest