Use lazy load hooks to extend ActiveRecord::Base #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR. I can get a release out for this as it looks straightforward. However, I stress that I am not really the maintainer of this gem, just the last person to have touched it. The person who originally created it has disappeared and I intend to try to get to understand it better but I haven't had the time. Help would be appreciated. |
|
Could you please rebase. I have updated the tests so that they should complete properly. |
Extend ActiveRecord::Base functionality only after ActiveRecord has been fully loaded. Ref: thoughtbot/factory_bot_rails#426
tagliala
force-pushed
the
bugfix/use-lazy-load-hooks
branch
from
2c79860 to
c36d1ad
Compare
|
Rebased, thanks Do you have access to rubygems to release a new version? |
That's great. Yes, I have access to rubygems. |
jrmhaig
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend ActiveRecord::Base functionality only after ActiveRecord has been fully loaded.
Ref: thoughtbot/factory_bot_rails#426
Hello, this is an attempt to fix a compatibility issue with the upcoming Factory Bot Rails 6.4.0.
This is the easiest thing that would work, but other approaches are possible, like an autoload functionality