Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring - Line thickness #126

Closed
2 of 13 tasks
dev3225 opened this issue Dec 7, 2022 · 1 comment · Fixed by #218
Closed
2 of 13 tasks

Refactoring - Line thickness #126

dev3225 opened this issue Dec 7, 2022 · 1 comment · Fixed by #218
Assignees
@motschel123 @PhlppKrmr
Labels
est. size 5 real. size 5 user story Scrum User Story
Milestone
Sprint 14 (Final ...

Comments

@dev3225
Copy link
Collaborator

dev3225 commented Dec 7, 2022 •
edited by PhlppKrmr
Loading

User story

  1. As a software developer
  2. I need the code for line thickness to be refactored
  3. So that it improves readability and reduces complexity

Acceptance criteria

  • Improved readability
  • Line thickness should be handled with WebGL.

Definition of done (DoD)

  • Feature/Bug/Change has been implemented

  • Application compiles successfully

  • Code is documented

  • Feature/Bug/Change is tested by at least one unit or e2e test

  • Tests have been passed without warnings (except "deprecated" warnings)

  • Changes have been reviewed

  • PR has been merged to dev branch

  • New dependencies have been added to bill of materials

  • Software architecture diagram has been updated

  • All acceptance criteria are fulfilled

  • Screenshot is attached to issue

DoD general criteria

  • Feature has been fully implemented
  • Feature has been merged into the mainline
  • All acceptance criteria were met
  • Product owner approved features
  • All tests are passing
  • Developers agreed to release
@dev3225 dev3225 added the user story Scrum User Story label Dec 7, 2022
@dev3225 dev3225 moved this to Product Backlog in amos2022ws03-feature-board Dec 7, 2022
@nicolaskolbenschlag
Copy link
Contributor

Here, also the bug, that the line is not visible if the values are zero and the line is not thick, should be addressed.

@sjelodari sjelodari moved this from Product Backlog to Sprint Backlog in amos2022ws03-feature-board Feb 1, 2023
@motschel123 motschel123 moved this from Sprint Backlog to In Progress in amos2022ws03-feature-board Feb 2, 2023
@motschel123 motschel123 linked a pull request Feb 4, 2023 that will close this issue
Naive thickness by duplicating lines with slight offset #218
Merged
PhlppKrmr added a commit that referenced this issue Feb 6, 2023
@PhlppKrmr
Merge branch 'dev' of origin into feature/#126-refactoring-line-thick…
5e7355d 
…ness

Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
@cypress cypress bot mentioned this issue Feb 6, 2023
Merged
motschel123 added a commit that referenced this issue Feb 6, 2023
@motschel123
Merge pull request #218 from amosproj/feature/#126-refactoring-line-t…
82f3633 
…hickness

Naive thickness by duplicating lines with slight offset
@github-project-automation github-project-automation bot moved this from In Progress to Awaiting Review in amos2022ws03-feature-board Feb 6, 2023
@sjelodari sjelodari moved this from Awaiting Review to Feature Archive in amos2022ws03-feature-board Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@motschel123 motschel123

@PhlppKrmr PhlppKrmr

Labels
est. size 5 real. size 5 user story Scrum User Story
Projects
amos2022ws03-feature-board
Status: Feature Archive
Milestone
Sprint 14 (Final Project Release)
Development

Successfully merging a pull request may close this issue.

Naive thickness by duplicating lines with slight offset amosproj/amos2022ws03-software-oscilloscope
5 participants
@dev3225 @motschel123 @sjelodari @nicolaskolbenschlag @PhlppKrmr