Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end tests #93

Closed
2 of 13 tasks
dev3225 opened this issue Nov 23, 2022 · 1 comment
Closed
2 of 13 tasks

Front end tests #93

dev3225 opened this issue Nov 23, 2022 · 1 comment
Assignees
Milestone

Comments

@dev3225
Copy link
Collaborator

dev3225 commented Nov 23, 2022

User story

  1. As a team member
  2. I need the front end to be tested under various test cases
  3. So that UI acts as desired

Acceptance criteria

  • All UI elements are working as desired.
  • Code coverage of 70+%

Definition of done (DoD)

  • Feature/Bug/Change has been implemented

  • Application compiles successfully

  • Code is documented

  • Feature/Bug/Change is tested by at least one unit or e2e test

  • Tests have been passed without warnings (except "deprecated" warnings)

  • Changes have been reviewed

  • PR has been merged to dev branch

  • New dependencies have been added to bill of materials

  • Software architecture diagram has been updated

  • All acceptance criteria are fulfilled

  • Screenshot is attached to issue

DoD general criteria

  • Feature has been fully implemented
  • Feature has been merged into the mainline
  • All acceptance criteria were met
  • Product owner approved features
  • All tests are passing
  • Developers agreed to release
@dev3225 dev3225 added user story Scrum User Story Priority High labels Nov 23, 2022
@dev3225 dev3225 added this to the Sprint 06 (Mid-Release) milestone Nov 23, 2022
@dev3225 dev3225 moved this to Product Backlog in amos2022ws03-feature-board Nov 23, 2022
@dev3225 dev3225 moved this from Product Backlog to Sprint Backlog in amos2022ws03-feature-board Nov 23, 2022
@dev3225 dev3225 moved this from Sprint Backlog to Product Backlog in amos2022ws03-feature-board Nov 30, 2022
@sjelodari sjelodari moved this from Product Backlog to Sprint Backlog in amos2022ws03-feature-board Nov 30, 2022
@dev3225 dev3225 moved this from Sprint Backlog to Product Backlog in amos2022ws03-feature-board Dec 7, 2022
@dev3225 dev3225 modified the milestones: Sprint 07, Sprint 13 Jan 25, 2023
@dev3225 dev3225 moved this from Product Backlog to Sprint Backlog in amos2022ws03-feature-board Jan 25, 2023
@leandertolksdorf leandertolksdorf self-assigned this Jan 26, 2023
@PhlppKrmr PhlppKrmr moved this from Sprint Backlog to In Progress in amos2022ws03-feature-board Jan 31, 2023
leandertolksdorf added a commit that referenced this issue Feb 1, 2023
* add cypress code coverage plugin

Signed-off-by: Leander Tolksdorf <leander.tolksdorf@fu-berlin.de>

* git ignore code coverage report

Signed-off-by: Leander Tolksdorf <leander.tolksdorf@fu-berlin.de>

* add general buttons test

Signed-off-by: Leander Tolksdorf <leander.tolksdorf@fu-berlin.de>

* add tests

Signed-off-by: Leander Tolksdorf <leander.tolksdorf@fu-berlin.de>

* merge indicator tests into one file, remove mock socket test

Signed-off-by: Leander Tolksdorf <leander.tolksdorf@fu-berlin.de>

* make line breaks after tests consistent

Signed-off-by: Leander Tolksdorf <leander.tolksdorf@fu-berlin.de>

* remove broken test for gnd-button

Signed-off-by: Leander Tolksdorf <leander.tolksdorf@fu-berlin.de>

* remove empty config from cy.visit

Signed-off-by: Leander Tolksdorf <leander.tolksdorf@fu-berlin.de>

---------

Signed-off-by: Leander Tolksdorf <leander.tolksdorf@fu-berlin.de>
Co-authored-by: Leander Tolksdorf <leander.tolksdorf@fu-berlin.de>
@leandertolksdorf leandertolksdorf moved this from In Progress to Awaiting Review in amos2022ws03-feature-board Feb 1, 2023
@sjelodari sjelodari moved this from Awaiting Review to Feature Archive in amos2022ws03-feature-board Feb 1, 2023
@leandertolksdorf
Copy link
Collaborator

Current test coverage:

Bildschirm­foto 2023-01-30 um 16 25 59

When running cypress tests, the coverage report gets saved into coveragefolder, we could include this in the CI output.

I added more tests for frontend-only stuff like tooltips, but I'm really struggling with tests that involve signals from the backend. See file cypress/e2e/2-indicators/line-indicators.cy.js: I tried mocking the websocket connection to send a test sample array. And the message is received at the frontend. Problems are:

  • The message data is received as a string like 1, 0, 0, ... instead of an array buffer.
  • Despite turning on the oscillator by clicking the start button, $osciEnabled is still false and the onmessage handler doesn't get to updating the other components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Feature Archive
Development

No branches or pull requests

3 participants