first working draft of implementation for #80 signal head

[nicolaskolbenschlag]

Signed-off-by: nicolaskolbenschlag nicolas.kolbenschlag@googlemail.com

[cypress]

---

Test summary

6 • 0 • 0 • 0

---

Run details

Project	sosci-frontend
Status	Passed
Commit	b3e8636
Started	Dec 2, 2022 7:29 AM
Ended	Dec 2, 2022 7:30 AM
Duration	00:52 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 107

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[PhlppKrmr]

Looks good so far, make sure to include tests to fulfill DoD.

One concern I have (not really scope of this issue) is performance. The signal head is once again computed on the CPU (in JS), we should look into how/if we can outsource some stuff onto the GPU.

[PhlppKrmr]

Can't retrospectively change from "Approve" to "Request changes" (afaik). This is only to indicate that tests are missing :)

[motschel123]

Can't retrospectively change from "Approve" to "Request changes" (afaik). This is only to indicate that tests are missing :)

As far as the changes only implement logic inside the plot, it is not quite possible to test for that in cypress, same applies for cursor feature.
E.g. in your feature for line thickness you only could test the presence of the switches and not the logic displaying the thick lines.

[motschel123]

LGTM.
As far as tests go it not really possible to test for plot only logic right now.