Implemented feature #62-cursor #114
Conversation
Signed-off-by: Marcel Schöckel <marcel.schoeckel@gmail.com>
Signed-off-by: Marcel Schöckel <marcel.schoeckel@gmail.com>
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
motschel123
requested review from
nicolaskolbenschlag,
PhlppKrmr and
jenswaechtler
and removed request for
nicolaskolbenschlag and
PhlppKrmr
| @@ -34,3 +34,4 @@ export const MIN_SWEEP = 0.5; // <= 1 | |||
| export const MAX_SWEEP = 2.0; // >= 1 | |||
| export const MIN_AMPLITUDE = 0.0; | |||
| export const MAX_AMPLITUDE = NUM_INTERVALS_HORIZONTAL / 2; | |||
| export const WAVE_CURSOR_SIZE = 50; | |||
There was a problem hiding this comment.
Can we rename to WAVE_CURSOR_WIDTH, would be more in line with the rest of the code :)
| @@ -103,9 +122,9 @@ | |||
| }; | |||
|
|
|||
| const update = () => { | |||
| for (let i = 0; i < channel_samples.length; i++) { | |||
| for (let i = 0; i < channelSamplesInjectCursor.length; i++) { | |||
There was a problem hiding this comment.
I'm not happy with an extra for loop only to "write" the cursor, currently looking for a way to fix this, will let you know if I find a better solution.
There was a problem hiding this comment.
I replaced the old loop, because the update function doesn't know where we currently are, it's just plots all the data.
So I first inject the cursor when data arrives.
Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
|
If you know a way to test it please let me know. It's the same as the basic waves, we can't really test for web gl rendering or the correct data injection from inside cypress. |
|
In #111 we had a similar issue where we don't quite know how to test plotting functionalities. I'd suggest we open up an issue that evaluates how to test those additionally to the frontend testing issue we still have in the sprint backlog. Are you fine with that? |
# Conflicts: # Apps/frontend/src/components/Waves.svelte
Co-authored-by: Philipp Kramer <philipp.kramer@fau.de> Co-authored-by: Leander Tolksdorf <leandet98@zedat.fu-berlin.de> Co-authored-by: Jan Degen <jan.degen@fau.de> Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
Implemented the cursor by injecting undefined data (not being displayed) in front of the new sample data.
Signed-off-by: Marcel Schöckel marcel.schoeckel@gmail.com