Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added channel id label #135

Merged
merged 5 commits into from
Dec 14, 2022
Merged

added channel id label #135

merged 5 commits into from
Dec 14, 2022

Conversation

rabbit-zero
Copy link
Collaborator

No description provided.

@cypress
Copy link

cypress bot commented Dec 12, 2022



Test summary

11 0 0 0


Run details

Project sosci-frontend
Status Passed
Commit 5f9308f
Started Dec 14, 2022 9:22 AM
Ended Dec 14, 2022 9:23 AM
Duration 00:53 💡
OS Linux Ubuntu - 22.04
Browser Chrome 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Collaborator

@leandertolksdorf leandertolksdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labels are working but I still have the weird behaivour like in your last pr.

Copy link
Collaborator

@PhlppKrmr PhlppKrmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labels are there, so looks good. Still, I'd prefer written out labels (Channel 1,...).
Additionally, the scaling looks a little scuffed atm. Maybe the "scaling fix" I introduced in #121 fixes this problem as well.

Copy link
Collaborator

@jandegen jandegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
…tons

Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
@jandegen jandegen merged commit 6beb1de into dev Dec 14, 2022
This was referenced Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants