Feature/#106 refactoring front end sliders #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace old sliders in Oscilloscope file with new Slider
…nd-sliders' into feature/#106-refactoring-front-end-sliders # Conflicts: # Apps/frontend/src/views/Oscilloscope.svelte
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
13 tasks
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
… feature/#106-refactoring-front-end-sliders
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
nicolaskolbenschlag
suggested changes
Dec 18, 2022
…ation Signed-off-by: Marcel Schöckel <marcel.schoeckel@gmail.com>
Signed-off-by: Marcel Schöckel <marcel.schoeckel@gmail.com>
rabbit-zero
approved these changes
Dec 19, 2022
nicolaskolbenschlag
approved these changes
Dec 20, 2022
motschel123
approved these changes
Dec 20, 2022
|
I will bypass branch protection and prevent outdating again, because it has been approved before being outdated, and the merge from dev doesn't relate to this feature. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves Slider in seperate file