Feature/#117 distribute button

[jenswaechtler]

Added a button for distributing signals evenly on the canvas

Image of three signals after clicking the button

[cypress]

---

Test summary

33 • 0 • 0 • 0

---

Run details

Project	sosci-frontend
Status	Passed
Commit	c81ea5d
Started	Jan 18, 2023 8:34 AM
Ended	Jan 18, 2023 8:36 AM
Duration	02:14 💡
OS	Linux Ubuntu - 22.04
Browser	Chrome 108

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[nicolaskolbenschlag]

I tried it. If I refresh the page, deactivate any instead of the first two signals, turn on and then click distribute, the plot looks like in the screenshot. The signals are distributed but so as they would be as if all 10 channels were active. Maybe this is a user-mistake from me. Could you please provide more information on how to test this?

Furthermore, you screenshot indicates that signal one (red) is at the bottom. I would prefer to maintain the order of the signals as used in the sliders.

[jenswaechtler]

I tried it. If I refresh the page, deactivate any instead of the first two signals, turn on and then click distribute, the plot looks like in the screenshot. The signals are distributed but so as they would be as if all 10 channels were active. Maybe this is a user-mistake from me. Could you please provide more information on how to test this?

Furthermore, you screenshot indicates that signal one (red) is at the bottom. I would prefer to maintain the order of the signals as used in the

I always distribute all 10 channels.
The description says to distribute all channels that are plotted. The channels that are turned off with the On Off button are still displayed and not removed from the plot. What we would need is a filter for the different channels to hide them completely. Then they should not be distributed anymore. So far we don't have that function.
For the screenshot, I changed the number of channels in the code to 3, because it gets very confusing with 10 channels.

I can change the arrangement of the channels.

[motschel123]

If I remember correct meeting right we should have all channels off on start per default and only disturbute channels that are switched on.
I'll try and implement that.

[nicolaskolbenschlag]

I clicked distribute, then switched off any channel except first and second, then clicked distribute again. The channels did not change then.

Further, I would prefer to maintain the order of the channels as given with the sliders. Currently it is reversed.

[motschel123]

The distribution should only happen once on button click now.
I'll try and refactor the distribution code slightly as it's not that easy to understand (e.g. offset is being calculated multiple times)

[motschel123]

I move the offset data into a store (Array<Writable> for performance), but svelte is not able to access it ( $offsetStore[index] won't work ). I did make it work within docker build but then npm run build for cypress fails.
So I just reverted and kept it as It was.

[PhlppKrmr]

For me the waves aren't even displayed. Tried out the #122 commit and there everything works fine?

This means I sadly can't test out the functionality, code-wise it looks like it'd work.
Additionally, two more things:

1. Can we please merge master into this branch so we actually use the new layout?
2. Can you add some JSDoc for the functions you added?

[nicolaskolbenschlag]

Looks good. But, when the button is clicked once, it distributes also when channels are (de-)activated. This is nice on one side and could be considered as a feature but I think it also has a drawback: namely when a custom offset is chosen via the slider for channel A and then channel B is activated or deactivated, the removes the user's custom offset of A. Maybe we should just distribute on-click and not always after the button is clicked once.
If this behavior is for purpose, it is also fine for me.

[motschel123]

@nicolaskolbenschlag can you elaborate on your comment? For me it only changes the offsets on channels that are switched on

[leandertolksdorf]

Whoops, just noticed the same thing as Philipp: In the indicators, the offsets should be pulled from the store like the amplitudes.

[PhlppKrmr]

Werid artifact on indicators as can be seen in video below. Happens when I reload the page and as the first action press "Turn on" (no Channels started).

[PhlppKrmr]

Signal seems oddly inconsistent (x-axis).
Edit: Checked if it also happens in #122 for me, it does. Seems to be a local problem, will investigate some more.

[PhlppKrmr]

@motschel123 You missed some deprecated files in the merge, should be fixed now. Also changed text to icon, added the test I mentioned in one of my previous comments and improved scalability of UI. Should be good to go now.

[PhlppKrmr]

Signal seems oddly inconsistent (x-axis). Edit: Checked if it also happens in #122 for me, it does. Seems to be a local problem, will investigate some more.

One more thing, does this also happen on any of you guys' machines or is this a purely local problem on my side?

Has been implemented