Feature/#122 rescale window #157
Conversation
Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
…usted in next commit Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
|
One more comment, I removed the Log for this version, if we want it back I'll add it again. |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Awesome! I think the background could need some kind of color shades or some separation of control units but that's something for another ticket. |
| * | ||
| * @param {MessageEvent} messageEvent - has poperty (Float64Array) data | ||
| */ | ||
| const socketOnMessage = (messageEvent) => { |
There was a problem hiding this comment.
Feels wrong to have the websocket and update buffer logic in a file named Layout. Not a big deal as it wasn't much better before.
Git didn't pick up that this was a rename from Oscilloscope.svelte -> Layout.svelte.
There was a problem hiding this comment.
Git didn't pick up on it cause it wasn't ;)
I created Layout.svelte separately to build the whole Layout from scratch so I don't have to mingle with the existing one. Will rename to Oscilloscope.svelte, was a good point.
|
Currently working on your and Mr. Eckert's recommendations, will hopefully be able to commit those changes later today. Else we'll simply keep the issue open for the next sprint and conclude it then. |
…h mobile and laptop screens Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
Sorry in advance for the humongous PR ;)
Works on Chromium and Firefox, @Mac guys, I'd very much appreciate it if you'd check if it works on Safari as well.