Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels now starting from 1 & Alternating row colors #181

Merged
merged 6 commits into from
Jan 22, 2023

Conversation

jandegen
Copy link
Collaborator

image

The bottom controll panel is now also scrollable

@jandegen jandegen requested a review from PhlppKrmr January 19, 2023 13:47
@jandegen jandegen linked an issue Jan 19, 2023 that may be closed by this pull request
12 tasks
@cypress
Copy link

cypress bot commented Jan 19, 2023



Test summary

33 0 0 0


Run details

Project sosci-frontend
Status Passed
Commit 2f1bdbb
Started Jan 22, 2023 5:25 PM
Ended Jan 22, 2023 5:27 PM
Duration 02:12 💡
OS Linux Ubuntu - 22.04
Browser Chrome 109

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@nicolaskolbenschlag nicolaskolbenschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a light theme, the table looks very dark. I personally would prefer a white and light-gray stripes instead of gray and dark-gray. Also the font-color should be updated because black on gray is not so easy to read.
image

Copy link
Collaborator

@PhlppKrmr PhlppKrmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some questions and am not quite happy with how the site scales. We could try merging #171 in the near future and then adapt the styling here to still work with responsiveness goals.

Apps/frontend/src/app.scss Show resolved Hide resolved
Apps/frontend/src/components/Slider.svelte Outdated Show resolved Hide resolved
Apps/frontend/src/const.js Outdated Show resolved Hide resolved
Apps/frontend/src/events.js Outdated Show resolved Hide resolved
Apps/frontend/src/app.scss Show resolved Hide resolved
Apps/frontend/src/app.scss Outdated Show resolved Hide resolved
@jandegen
Copy link
Collaborator Author

With a light theme, the table looks very dark. I personally would prefer a white and light-gray stripes instead of gray and dark-gray. Also the font-color should be updated because black on gray is not so easy to read. image

Now fixed with :

image

Apps/frontend/src/app.scss Outdated Show resolved Hide resolved
Apps/frontend/src/events.js Outdated Show resolved Hide resolved
Jan Degen and others added 3 commits January 22, 2023 17:26
Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
Signed-off-by: Philipp Kramer <philipp.p.kramer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel naming - rework
4 participants