Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#164 channels for visualization #184

Merged
merged 11 commits into from
Jan 23, 2023
Merged

Feature/#164 channels for visualization #184

merged 11 commits into from
Jan 23, 2023

Conversation

jenswaechtler
Copy link
Contributor

  • Except for one channel all others show a signal
  • A sine curve is now displayed whose amplitude changes periodically
  • A curve with random data between -1 and 1
  • A curve with random data that changes little from the previous value. It looks like a stock market price.
  • In addition, a sine, saw and square curve without noise was inserted

Here you can see the new type of curves
grafik

@jenswaechtler
Add new field prev_rand_value to TenChannelSampleGenerator
e3162a2 
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
@jenswaechtler
Add function for generating sample data between -1 and 1
40b8dcd 
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
@jenswaechtler
Change forth signal to output of random_bounded_values
c47981e 
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
@jenswaechtler
Add tests for random sample data
2866b55 
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
@jenswaechtler
Introduce const for random difference
fd18a9d 
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
@jenswaechtler
Introduce sinus curve with changing amplitude
61549ae 
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
@jenswaechtler
Add no noise signals
bd77522 
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
@jenswaechtler jenswaechtler linked an issue Jan 22, 2023 that may be closed by this pull request
Channels for visualization #164
Closed
13 tasks
@cypress
Copy link

cypress bot commented Jan 22, 2023 •
edited
Loading


Test summary

33 • 0 • 0 • 0

Run details
Project sosci-frontend
Status Passed
Commit bc5365b
Started Jan 23, 2023 6:11 PM
Ended Jan 23, 2023 6:15 PM
Duration 03:40 💡
OS Linux Ubuntu - 22.04
Browser Chrome 109

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jenswaechtler
Change Wave to be in -1 1 range
e31e0f6 
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
@jenswaechtler
Fix test to respect not periodic functions
7f3ba21 
Signed-off-by: Jens Wächtler <jens.f.waechtler@fau.de>
@jenswaechtler
Merge remote-tracking branch 'origin/dev' into feature/#164-channels-…
44d32f4 
…for-visualization
rabbit-zero
rabbit-zero approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@rabbit-zero rabbit-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different waves works for me. I'm not that familiar with rust but lgtm

@jenswaechtler jenswaechtler merged commit e3c641e into dev Jan 23, 2023
This was referenced Jan 25, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabbit-zero rabbit-zero rabbit-zero approved these changes

@leon-juenemann leon-juenemann Awaiting requested review from leon-juenemann

@PhlppKrmr PhlppKrmr Awaiting requested review from PhlppKrmr

@nicolaskolbenschlag nicolaskolbenschlag Awaiting requested review from nicolaskolbenschlag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Channels for visualization
3 participants
@jenswaechtler @rabbit-zero @nicolaskolbenschlag