-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#153 webgl minimal #186
Conversation
Passing run #525 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Performance is a lot better since last commit (webgl.DYNAMIC_DRAW) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it doesn't seem like STATIC_DRAW vs DYNAMIC_DRAW makes much of a difference, but both implementation quite well on my machine. Great work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good as a base we can work with. Only have a few cleanup recommendations.
Apart from that I once again looked into the (time sweep) slider performance loss bug:
If we change the time sweep a lot we eventually run into a performance loss. This happens both in your and in the webgl-plot implementation, in yours it is merely more pronounced (earlier noticeable).
After chaning the time sweep a few times:
I personally would still say we can merge this current version and build upon it with (at least) one person taking on the task of improving performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. Good work!
5a04227
to
51f97fe
Compare
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
51f97fe
to
117edd7
Compare
My second attempt to draw the channels with WebGL.
Now with fewer changes to the existing code structure. Was simply not feasible otherwise to merge after all the new changes.
I tried out a lot of different ways to draw the signals. In the end, I opted for this easy approach with minimal changes to the code.
Signal heads are missing. -> new ticket.