Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#153 webgl minimal #186

Merged
merged 8 commits into from
Jan 31, 2023
Merged

Feature/#153 webgl minimal #186

merged 8 commits into from
Jan 31, 2023

Conversation

leon-juenemann
Copy link
Collaborator

My second attempt to draw the channels with WebGL.
Now with fewer changes to the existing code structure. Was simply not feasible otherwise to merge after all the new changes.

I tried out a lot of different ways to draw the signals. In the end, I opted for this easy approach with minimal changes to the code.

Signal heads are missing. -> new ticket.

@leon-juenemann leon-juenemann linked an issue Jan 24, 2023 that may be closed by this pull request
@cypress
Copy link

cypress bot commented Jan 24, 2023

Passing run #525 ↗︎

0 33 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Feature/#153 webgl minimal
Project: sosci-frontend Commit: 51f97feaf0
Status: Passed Duration: 03:05 💡
Started: Jan 31, 2023 2:59 PM Ended: Jan 31, 2023 3:02 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@leon-juenemann
Copy link
Collaborator Author

Performance is a lot better since last commit (webgl.DYNAMIC_DRAW)

Copy link
Collaborator

@motschel123 motschel123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it doesn't seem like STATIC_DRAW vs DYNAMIC_DRAW makes much of a difference, but both implementation quite well on my machine. Great work

Copy link
Collaborator

@PhlppKrmr PhlppKrmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good as a base we can work with. Only have a few cleanup recommendations.

Apart from that I once again looked into the (time sweep) slider performance loss bug:
If we change the time sweep a lot we eventually run into a performance loss. This happens both in your and in the webgl-plot implementation, in yours it is merely more pronounced (earlier noticeable).

In the beginning:
image

After chaning the time sweep a few times:
image

I personally would still say we can merge this current version and build upon it with (at least) one person taking on the task of improving performance.

Apps/frontend/src/components/Waves.svelte Outdated Show resolved Hide resolved
Apps/frontend/src/components/Waves.svelte Show resolved Hide resolved
Copy link
Contributor

@nicolaskolbenschlag nicolaskolbenschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Good work!

Leon Jünemann added 8 commits January 31, 2023 16:05
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Signed-off-by: Leon Jünemann <leon.jueenmann@campus.tu-berlin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signal lines not contiguous
4 participants