Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conditional requirement for openSUSE #856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add conditional requirement for openSUSE #856

wants to merge 1 commit into from

Conversation

suchow
Copy link
Member

@suchow suchow commented Jul 22, 2018

Merging #797.

@suchow suchow changed the title Add conditional requirement Add conditional requirement for openSUSE Jul 22, 2018
@suchow suchow mentioned this pull request Jul 22, 2018
Closed
@suchow
Copy link
Member Author

suchow commented Jul 23, 2018

@joshmgrant Could you take another look at this? Getting build failures, something about the sys_platform not being recognized.

@jayvdb
Copy link
Contributor

jayvdb commented Mar 8, 2019

This wont work consistently, as https://pypi.org/project/python-dbm/ is 404 , so lots of tools will not be able to resolve this requirement.

And also lots of in-use versions of setuptools/pip/packaging/etc which had problems with sys_platform. Search online for setuptools+markers+sys_platform to get a feel for that.

It is now at https://build.opensuse.org/package/show/devel:languages:python/python-proselint and has the necessary conditionals there.

IMO this should be closed.

@Nytelife26 Nytelife26 added the status: awaiting-triage Issues and PRs awaiting investigation and relabelling. label May 29, 2021
@Nytelife26
Copy link
Member

I do not know enough about OpenSUSE to comment on whether or not this is still an issue, so any external knowledge would be appreciated.

@Nytelife26 Nytelife26 self-assigned this Jul 27, 2023
@Nytelife26 Nytelife26 added bug: unconfirmed Bugs that need to be reproduced. type: fix Issues and PRs related to bugs. priority: high Issues and PRs that should be resolved as soon as possible. version: patch Issues and PRs with bug fixes belonging to the next patch release. status: needs-help Issues and PRs that require volunteer assistance to proceed. cat: maintenance Issues and PRs related to the maintenance of a module. and removed status: awaiting-triage Issues and PRs awaiting investigation and relabelling. labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshmgrant joshmgrant

@Nytelife26 Nytelife26

Labels
bug: unconfirmed Bugs that need to be reproduced. cat: maintenance Issues and PRs related to the maintenance of a module. priority: high Issues and PRs that should be resolved as soon as possible. status: needs-help Issues and PRs that require volunteer assistance to proceed. type: fix Issues and PRs related to bugs. version: patch Issues and PRs with bug fixes belonging to the next patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suchow @jayvdb @Nytelife26 @joshmgrant