Unreference stderr reading, so it doesn't keep the loop running

amphp · Jun 23, 2017 · 8ecfed5 · 8ecfed5
1 parent 8c726c6
commit 8ecfed5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/composer.json b/composer.json
@@ -22,7 +22,7 @@
     ],
     "require": {
         "amphp/amp": "^2",
-        "amphp/byte-stream": "^1",
+        "amphp/byte-stream": "^1.1",
         "amphp/parser": "^1",
         "amphp/process": "^0.2"
     },

diff --git a/lib/Process/ChannelledProcess.php b/lib/Process/ChannelledProcess.php
@@ -67,7 +67,9 @@ public function start() {
         $this->process->start();
         $this->channel = new ChannelledStream($this->process->getStdout(), $this->process->getStdin());
 
+        /** @var ByteStream\ResourceInputStream $childStderr */
         $childStderr = $this->process->getStderr();
+        $childStderr->unreference();
 
         asyncCall(function () use ($childStderr) {
             $stderr = new ByteStream\ResourceOutputStream(\STDERR);