New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add previous exception message when fail to start process #192

Merged

trowski merged 1 commit into amphp:2.x from thgs:add-more-messaging-on-process-start-fail

Nov 29, 2023

Contributor

thgs commented Nov 26, 2023

Really not sure about this, but I see you do it around the codebase with ContextException.

An alternative would be

throw new ContextException(
    sprintf("Starting the process failed (%s)", $exception->getMessage()), 
    previous: $exception
);

Next step would be a small API for ContextException itself?


          Add previous exception message when fail to start process

3a86af4

trowski merged commit 8b8f33a into amphp:2.x

renovate bot referenced this pull request in ben-challis/sql-migrations


          Update Composer runtime dependencies (#215)

f4ec0ac

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [amphp/parallel](https://github.com/amphp/parallel) | `2.2.3` ->
`2.2.4` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/amphp%2fparallel/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/amphp%2fparallel/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/amphp%2fparallel/2.2.3/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/amphp%2fparallel/2.2.3/2.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [symfony/finder](https://symfony.com)
([source](https://github.com/symfony/finder)) | `6.4.0-RC1` -> `6.4.0`
|
[![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2ffinder/6.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2ffinder/6.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2ffinder/6.4.0-RC1/6.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2ffinder/6.4.0-RC1/6.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>amphp/parallel (amphp/parallel)</summary>

### [`v2.2.4`](https://github.com/amphp/parallel/releases/tag/v2.2.4):
2.2.4

[Compare
Source](https://github.com/amphp/parallel/compare/v2.2.3...v2.2.4)

#### What's Changed

- Fixed `SocketIpcHub` not removing the temporary socket file if the
object was not explicitly closed before destruction (fixes
[#&#8203;183](https://github.com/amphp/parallel/issues/183)).
- Add previous exception message when fail to start process by
[@&#8203;thgs](https://github.com/thgs) in
[https://github.com/amphp/parallel/pull/192](https://github.com/amphp/parallel/pull/192)

#### New Contributors

- [@&#8203;thgs](https://github.com/thgs) made their first
contribution in
[https://github.com/amphp/parallel/pull/192](https://github.com/amphp/parallel/pull/192)

**Full Changelog**:
amphp/parallel@v2.2.3...v2.2.4

</details>

<details>
<summary>symfony/finder (symfony/finder)</summary>

### [`v6.4.0`](https://github.com/symfony/finder/releases/tag/v6.4.0)

[Compare
Source](https://github.com/symfony/finder/compare/v6.4.0-RC1...v6.4.0)

**Changelog**
(symfony/finder@v6.4.0-RC2...v6.4.0)

-   no significant changes

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ben-challis/sql-migrations).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

thgs deleted the add-more-messaging-on-process-start-fail branch

December 3, 2023 10:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet