Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements on examples #194

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

thgs
Copy link
Contributor

@thgs thgs commented Jan 1, 2024

Shows output like so now:

➜  parallel git:(7b53bad) ✗ php examples/context.php
Waiting 2 seconds to send start data...
Demonstrating how alive the parent is for the 1st time.
Demonstrating how alive the parent is for the 2nd time.
Received the following from parent: Start data
Sleeping for 3 seconds...
Demonstrating how alive the parent is for the 3rd time.
Demonstrating how alive the parent is for the 4th time.
Demonstrating how alive the parent is for the 5th time.
Received the following from child: Data sent from child.
Sleeping for 2 seconds...
Demonstrating how alive the parent is for the 6th time.
Demonstrating how alive the parent is for the 7th time.
Process ended with value 42!

➜  parallel git:(7b53bad) ✗ php examples/process.php                   
Waiting 2 seconds to send start data...
Demonstrating how alive the parent is for the 1st time.
Demonstrating how alive the parent is for the 2nd time.
Received the following from parent: Start data
Sleeping for 3 seconds...
Demonstrating how alive the parent is for the 3rd time.
Demonstrating how alive the parent is for the 4th time.
Demonstrating how alive the parent is for the 5th time.
Received the following from child: Data sent from child.
Sleeping for 2 seconds...
Demonstrating how alive the parent is for the 6th time.
Demonstrating how alive the parent is for the 7th time.
Process ended with value 42!

@thgs thgs changed the title Small examples improvement on messaging Small improvements on examples Jan 1, 2024
@thgs
Copy link
Contributor Author

thgs commented Jan 3, 2024

@trowski @kelunik

this 62d2f81 can also go away, but the comments point to the wrong filename 🤷‍♂️

@trowski trowski merged commit 024369c into amphp:2.x Jan 7, 2024
7 checks passed
@trowski
Copy link
Member

trowski commented Jan 7, 2024

Thanks @thgs!

@thgs thgs deleted the small-output-improvement-examples branch January 8, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants