-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use inheritance for expression classes #35
Comments
vitaut
added a commit
that referenced
this issue
Feb 13, 2015
vitaut
added a commit
that referenced
this issue
Feb 14, 2015
vitaut
added a commit
that referenced
this issue
Feb 16, 2015
Fixed for new expression types as of 02ca9fa. Need to do the same for ASL expressions. |
vitaut
added a commit
that referenced
this issue
Feb 18, 2015
Complete in 449ba37. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This shouldn't be allowed, because it undermines type safety:
So make expression classes independent types instantiated from a common template instead of using inheritance. This is similar to smart pointers and effectively expression classes are like smart pointers but with a nice API.
The text was updated successfully, but these errors were encountered: