Compile fails with gsl 2.1

[opoplawski]

Working on updating gsl to 2.1 in Fedora. mp fails with:

/builddir/build/BUILD/mp-35060ba2a59f2b0f0fd622ed9df678f142f846ed/src/gsl/amplgsl.c:1493:14: error: too many arguments to function 'gsl_sf_ellint_D_e'
 WRAP_CHECKED(gsl_sf_ellint_D, ARGS3_PREC)
              ^

In gsl 2 they dropped the unused third argument 'n'. Something like:

#if GSL_MAJOR_VERSION >= 2
WRAP_CHECKED(gsl_sf_ellint_D, ARGS2_PREC)
#else 
WRAP_CHECKED(gsl_sf_ellint_D, ARGS3_PREC)
#endif 

Should work.

[vitaut]

I've committed the fix you propose in eeb32b4, but haven't updated gsl yet because it fails to compile on one of the supported platforms (Windows with MSVC). Thanks!

[vitaut]

Implemented more fixes and updated gsl module to version 2.1 in 635f552.

[opoplawski]

We have a test failure with gsl 1.16:

[ RUN      ] GSLTest.EllInt
unknown file: Failure
C++ exception with description "invalid number of arguments in function call" thrown in the test body.
[  FAILED  ] GSLTest.EllInt (157 ms)

Works with gsl 2.1 though.

[vitaut]

Fixed in f34afb3, thanks.

[opoplawski]

Confirmed, thanks again.