-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for permuted indices in NL segments #92
Comments
In the |
Segment that need checks: |
Done for logical constraints ( |
Looks like adding all objectives at once and then updating them with expressions and types is faster (and easier) than adding them incrementally and checking if they are ordered:
https://github.com/ampl/mp/blob/master/test/nl-benchmark.cc |
Done for objectives. |
Done for constraints. Need to do the same for common expressions and functions. |
Done for common expressions. |
Also check if avoiding |
All permuted indices are handled correctly now. |
Remaining work here:
|
Here are nl-benchmark results on https://github.com/ampl/mp/tree/3cd123f67fb368cc3ecf49ddbd0c461ac3b750d7 (Dec 30, 2014): Binary:
Text:
Tested on machine with the following specs (titan): |
Results on https://github.com/ampl/mp/tree/75791139a06eb8e021b6493fe46a863956f2bb8a (Mar 25, 2016): Binary:
Text:
Text slightly improved, binary the same. |
Results on e6afdba with fixed handling of permuted indices: Binary:
Text:
|
Avoiding |
Ill-formed .nl files can have indices permuted. This doesn't affect the NL reader because it passes the indices to the client, but
NLProblemBuilder
should detect it and do something about it like reporting an error.The text was updated successfully, but these errors were encountered: