Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(session replay) baseline console tracking in sr #961

Merged
merged 5 commits into from
Feb 21, 2025
Merged

feat(session replay) baseline console tracking in sr #961

merged 5 commits into from
Feb 21, 2025

Conversation

jxiwang
Copy link

@jxiwang jxiwang commented Feb 18, 2025

Summary

Adding SR recording plugin to start tracking console logging. Includes a slight alteration to the Logger class to avoid Uncaught RangeError: Maximum call stack size exceeded error when recording console logs (error, warn, etc).

This is the baseline feature to start collecting the data, not inclusive of more remote config options.

Note: Prepping this PR for review, since it touches analytics-core. No rush to merge currently.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@jxiwang jxiwang changed the title feat(session replay); feat(session replay) baseline console tracking in sr Feb 18, 2025
Copy link

@lewgordon-amplitude lewgordon-amplitude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though you may want to consider moving some of the Github comments to code comments.

@jxiwang jxiwang merged commit 2b6b443 into v1.x Feb 21, 2025
4 checks passed
@jxiwang jxiwang deleted the SR-79 branch February 21, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants