Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSString *deviceId not initialized properly in _getDeviceId #20

Closed
cojo opened this issue Nov 25, 2014 · 1 comment
Closed

NSString *deviceId not initialized properly in _getDeviceId #20

cojo opened this issue Nov 25, 2014 · 1 comment

Comments

@cojo
Copy link

cojo commented Nov 25, 2014

Hi,

If a given binary has the "correct" layout in the final build, it is possible that Amplitude crashes the application (confirmed in iOS5.1.1 on an iPad1 at least).

In Amplitude.m on line 835:
NSString *deviceId;
needs to be:
NSString *deviceId = nil;

Otherwise the deviceId can end up pointing to arbitrary garbage that may pass the subsequent conditionals and thus never properly initializing the deviceId with a meaningful string.

Let me know if you need more information.

Thanks!
-cojo

@curtisliu
Copy link
Member

Thanks! Fixed in 2549ade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants