feat: Add support for watchOS #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daltonclaybrook Thanks! This is great. We will review it soon. |
haoliu-amp
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
@daltonclaybrook LGTM. Have you tried logEvent in your watchOS app? Any issues with that?
|
@haoliu-amp I'm planning to do some testing on this today and will let you know. |
|
@haoliu-amp I did some basic testing yesterday on-device and was seeing events in the dashboard. Not a comprehensive test, but anecdotally, it seems to be working. |
|
@daltonclaybrook Thank you spending time to do the testing! We will release it very soon! |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 16, 2021
# [8.1.0](v8.0.0...v8.1.0) (2021-03-16) ### Features * Add support for watchOS ([#330](#330)) ([9db310a](9db310a))
|
🎉 This PR is included in version 8.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #247
This PR updates the SDK to include support for watchOS. The only consequential change to the SDK is the addition of a new type:
AMPBackgroundNotifier. The doc comment in that file explains its purpose:I've also updated the Podspec to add watchOS support. Feel free to make changes to this branch as you see fit.
Checklist