Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EU SSL pinning cert, extent it to support multiple domains #403

Merged
merged 4 commits into from
Jul 15, 2022

Conversation

liuyang1520
Copy link
Collaborator

Summary

  • feat: add EU SSL pinning cert, extent it to support multiple domains

The EU cert file is downloaded from https://www.amazontrust.com/repository/, which is used by EU endpoint.

As we currently don't support reinit API key, so we don't need to support runtime endpoint switch either. This feature is not covered in this PR.

Tests

  • Unit tests (actually they are real integration tests)
  • Event observed in EU Amplitude with SSL pinning enabled
  • Event observed in US Amplitude with SSL pinning enabled

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:
    No

@liuyang1520 liuyang1520 requested a review from haoliu-amp July 14, 2022 15:48
@liuyang1520 liuyang1520 merged commit aba104d into main Jul 15, 2022
@liuyang1520 liuyang1520 deleted the add-eu-ssl-pinning branch July 15, 2022 22:57
github-actions bot pushed a commit that referenced this pull request Jul 19, 2022
# [8.11.0](v8.10.2...v8.11.0) (2022-07-19)

### Bug Fixes

* deprecation fix ([#404](#404)) ([2f1203c](2f1203c))

### Features

* add EU SSL pinning cert, extent it to support multiple domains ([#403](#403)) ([aba104d](aba104d))
@github-actions
Copy link

🎉 This PR is included in version 8.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

junjie added a commit to junjie/Amplitude-iOS that referenced this pull request Sep 6, 2022
…entify-object

* commit 'f07749967fb8e628f9f2c743fab2ba6600574d85':
  chore(release): 8.12.0 [skip ci]
  feat: expose more function signature for logEvent (amplitude#409)
  chore: use the reusable workflow to create jira issue (amplitude#408)
  chore(release): 8.11.1 [skip ci]
  fix: turn requiringSecureCoding on, adjust the available version (amplitude#407)
  chore(release): 8.11.0 [skip ci]
  fix: deprecation fix (amplitude#404)
  feat: add EU SSL pinning cert, extent it to support multiple domains (amplitude#403)
  chore(release): 8.10.2 [skip ci]
  Revert "Compile with code coverage enabled (amplitude#398)" (amplitude#402)
  chore(release): 8.10.1 [skip ci]
  fix: wrong carrier info with deprecated method (amplitude#400)
  Compile with code coverage enabled (amplitude#398)
  chore(release): 8.10.0 [skip ci]
  feat: Add versionId to tracking plan data (amplitude#392)
  chore(release): 8.9.0 [skip ci]
  fix: fix release action
  Update Podfile.lock
  feat: Add support on Swift Package Manager for WatchOS (amplitude#381)
  docs: add Ampli SDK reference (amplitude#385)

# Conflicts:
#	Sources/Amplitude/AMPURLSession.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants