-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PrivacyInfo) SPM/Cocoapods support for privacy manifest #487
Conversation
This should be accepted. |
Merging this, thanks @sdurban! |
🎉 This PR is included in version 8.18.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hello @wlxo0401 and @sdurban. Unfortunately, these changes do not effectively address the issue.
produce a copy into the target bundle (as per official documentation) also for static linking process there is strongly recommend to use different way of attaching resources into the pod should be used.
so the spec should looks like this.
Current Amplitude-iOS version 8.19.1 for cocoapods linked statically produce a compile error Multiple commands produce .... PrivacyInfo.xcprivacy .... script phase “[CP] Copy Pods Resources” if i add my own PrivacyInfo.xcprivacy file into the target. What do you think about it? |
Hello @astrokin, You're right. There is a problem with cocoapods definition if you use cocoapods without If you use Perhaps it would be best to leave the I'll submit another PR this week to address this issue, @crleona or you can fix It with a PR @astrokin if you want. |
Summary
This PR adds exporting of the PrivacyInfo information added in version 8.18.0 for use via SPM and Cocoapods.
I have tested it with SPM and Cocoapods sample projects, and now it successfully fetches the information.
The process to add it in Cocoapods is the same as used by multiple projects. Ref. CocoaPods/CocoaPods#10325 (comment) and to add it in SPM, I have looked at other projects such as Revenuecat https://github.com/RevenueCat/purchases-ios/blob/main/Package.swift.
Issues Related:
#482
#470
Thanks for Amplitude!