Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch and log error from flag config poller request #10

Merged
merged 1 commit into from
Oct 4, 2022
Merged

fix: catch and log error from flag config poller request #10

merged 1 commit into from
Oct 4, 2022

Conversation

bgiori
Copy link
Collaborator

@bgiori bgiori commented Oct 4, 2022

Summary

  • The error getting thrown from the fetcher to the poller was not being caught, which would cause a crash.
  • Add content and type and accept headers to the poller request.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@bgiori bgiori requested a review from kevinpagtakhan October 4, 2022 00:51
@bgiori bgiori merged commit 6e6b051 into main Oct 4, 2022
@bgiori bgiori deleted the catch-poller-error branch October 4, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

@kevinpagtakhan kevinpagtakhan kevinpagtakhan approved these changes

@nirmal91 nirmal91 nirmal91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bgiori @nirmal91 @kevinpagtakhan @qingzhuozhen