-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting headers #10
Conversation
If present, any headers specified in the options passed to connectRequest will be applied to the request.
This looks great! Thanks for adding a test and update the README. Seems I'm currently on vacation so I will have to take another look when I get back. |
Oh OK, I didn't notice you had that set up. I'll run it and fix whatever
needs fixing. Enjoy your vacation, and stop checking github ;)
…On Feb 17, 2017 9:14 AM, "Ryan Ashcraft" ***@***.***> wrote:
This looks great! Thanks for adding a test and update the README. Seems npm
run lint is complaining, though.
I'm currently on vacation so I will have to take another look when I get
back.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAkzRtIt0sM5snm5CqMKVuTLVlV43Ytks5rddWOgaJpZM4MD5OR>
.
|
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 88.34% 88.57% +0.22%
==========================================
Files 7 7
Lines 206 210 +4
==========================================
+ Hits 182 186 +4
Misses 24 24
Continue to review full report at Codecov.
|
@adamsanderson Can you modify the |
The `MUTATE_ASYNC` action type now supports custom headers by setting the `headers` key in the action's `options` hash.
Sure, no problem. For one reason or another I assumed that the both the mutations and the query branches shared the same request configuration code and didn't look closely enough. This should do the trick. |
@adamsanderson Thanks for this change! |
Addresses #3 by allowing users to set
options.headers
inconnectRequest
.