Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include response body in all success and failure actions #39

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Include response body in all success and failure actions #39

merged 1 commit into from
Mar 15, 2017

Conversation

ryanashcraft
Copy link
Contributor

No description provided.

trashstack
trashstack approved these changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@trashstack trashstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

May be worth noting the inconsistent arg ordering in the docs.

@ryanashcraft ryanashcraft merged commit 8b6eaf4 into amplitude:master Mar 15, 2017
@ryanashcraft ryanashcraft mentioned this pull request Mar 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trashstack trashstack trashstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanashcraft @trashstack