Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store request controller, rather than its instance #69

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

acontreras89
Copy link
Contributor

Fix #68.

@acontreras89
Copy link
Contributor Author

You may want to rename the property to controller (rather than request) to avoid confusion.

@ryanashcraft ryanashcraft changed the base branch from master to 2.0 April 25, 2017 19:36
@ryanashcraft
Copy link
Contributor

@acontreras89 Good catch. Putting this on the 2.0 branch we're tracking to release along with a few breaking changes.

@ryanashcraft ryanashcraft merged commit 5cf5c8f into amplitude:2.0 Apr 25, 2017
@acontreras89
Copy link
Contributor Author

I found this bug while testing fetch adapter :) I told you about it in some other issue, and it has finally made it to npm.

@ryanashcraft I've been wanting to ask, is there any other channel to get in touch with you (redux-query maintainers) besides this repo? Perhaps a gitter/slack/discord community?

I've been spending quite some time with your library lately, and I'd love to share some of my thoughts with you in a more direct manner.

Also, is there any info on the breaking changes that 2.0 will introduce?

@acontreras89 acontreras89 deleted the ac-restore-controller branch April 25, 2017 20:58
@ryanashcraft ryanashcraft mentioned this pull request Apr 25, 2017
@ryanashcraft
Copy link
Contributor

@acontreras89 For now I want to keep everything in Github as my time is pretty stretched and don't want to set expectations that I can't fulfill. Also lets other contributors chime in when appropriate.

If you have ideas, please create an issue(s). I've also made a 2.0 issue for open discussion:
#70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants