Add Site Health test to warn sites when fallback publisher logo will be used for Schema.org metadata #5120
Labels
Changelogged
Whether the issue/PR has been added to release notes.
Groomed
Needs sizing
P2
Low priority
Punted
Schema.org Metadata
Site Health
WS:Core
Work stream for Plugin core
Milestone
Feature description
Users often reported structured data errors related to
publisher.logo.url
being empty. For this reason, we provide a fallback imageamp-page-fallback-wordpress-publisher-logo.png
. Nevertheless, this is not ideal.There should be a Site Health test that warns administrators when
amp_get_publisher_logo()
returns an image other than the fallback ofamp-page-fallback-wordpress-publisher-logo.png
.This field is empty for sites that do not have a Custom Logo or Site Icon set in the Customizer, or a custom
amp_site_icon_url
filter was not used. See logic here:amp-wp/includes/amp-helper-functions.php
Lines 1593 to 1641 in afab6f0
The
amp_get_publisher_logo()
should perhaps take a$default
arg that is set toamp-page-fallback-wordpress-publisher-logo.png
whennull
. Then we can use this in the Site Health test by passingfalse
to determine if a publisher logo is defined.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: