Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Site Health test to warn sites when fallback publisher logo is used #7124

Merged
merged 10 commits into from
Jun 13, 2022
Merged

Add Site Health test to warn sites when fallback publisher logo is used #7124

merged 10 commits into from
Jun 13, 2022

Conversation

dhaval-parekh
Copy link
Collaborator

@dhaval-parekh dhaval-parekh commented May 30, 2022 •
edited by westonruter
Loading

Summary

Fixes #5120

Screen Shot 2022-06-13 at 11 09 01

Screen Shot 2022-06-13 at 11 08 02

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh force-pushed the enhancement/publisher-logo branch from c224aea to ff04714 Compare June 1, 2022 03:30
@dhaval-parekh dhaval-parekh marked this pull request as ready for review June 1, 2022 04:27
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022 •
edited
Loading

Plugin builds for 8b24389 are ready 🛎️!

westonruter
westonruter requested changes Jun 1, 2022
View reviewed changes
includes/amp-helper-functions.php Outdated Show resolved Hide resolved
src/Admin/SiteHealth.php Outdated Show resolved Hide resolved
@dhaval-parekh dhaval-parekh self-assigned this Jun 10, 2022
@westonruter westonruter added this to the v2.4 milestone Jun 10, 2022
@dhaval-parekh dhaval-parekh force-pushed the enhancement/publisher-logo branch from 8a4c060 to 042d551 Compare June 12, 2022 11:36
westonruter
westonruter reviewed Jun 13, 2022
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that the test should have the amp_ prefix.

src/Admin/SiteHealth.php Outdated Show resolved Hide resolved
tests/php/src/Admin/SiteHealthTest.php Outdated Show resolved Hide resolved
@westonruter
Merge branch 'develop' of github.com:ampproject/amp-wp into enhanceme…
5c14622 
…nt/publisher-logo

* 'develop' of github.com:ampproject/amp-wp:
  Update amp-toolbox-php to 0.11.2
  Update the ecosystem files
@westonruter
Add amp prefix to publisher_logo test
eec251b
@westonruter
Add action to publisher logo test and improve strings
8b24389
@westonruter westonruter modified the milestones: v2.4, v2.3 Jun 13, 2022
@westonruter westonruter enabled auto-merge June 13, 2022 18:13
@westonruter westonruter merged commit 2f3ada6 into develop Jun 13, 2022
@westonruter westonruter deleted the enhancement/publisher-logo branch June 13, 2022 18:15
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
@westonruter westonruter changed the title Add Site Health test to warn sites when fallback publisher logo. Add Site Health test to warn sites when fallback publisher logo is used Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@milindmore22 milindmore22 Awaiting requested review from milindmore22

Assignees

@dhaval-parekh dhaval-parekh

Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.

Add Site Health test to warn sites when fallback publisher logo will be used for Schema.org metadata
2 participants
@dhaval-parekh @westonruter