Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove React 17 requirement for certain features #7489

Closed
westonruter opened this issue Mar 16, 2023 · 1 comment · Fixed by #7490
Closed

Remove React 17 requirement for certain features #7489

westonruter opened this issue Mar 16, 2023 · 1 comment · Fixed by #7490
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Milestone
v2.4.1

Comments

@westonruter
Copy link
Member

Feature Description

Let's undo aspects of #7421 which made certain services dependent on React 17. As seen in the below Make/Core post, any React 17 code will continue to work with React 18 by invoking a legacy API:

image

In particular, this is considering the following line (at least):

amp-wp/src/Admin/AfterActivationSiteScan.php

Line 104 in f8249c1

( $react instanceof _WP_Dependency && version_compare( $react->ver, '18', '<' ) )

Related: #7394

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response
@westonruter westonruter added the Enhancement New feature or improvement of an existing one label Mar 16, 2023
@westonruter westonruter added this to the v2.4.1 milestone Mar 16, 2023
@westonruter westonruter mentioned this issue Mar 16, 2023
Closed
thelovekesh added a commit that referenced this issue Mar 16, 2023
@thelovekesh
Revert #7421
5aa2b26 
- See #7489
@thelovekesh thelovekesh mentioned this issue Mar 16, 2023
Merged
2 tasks
@thelovekesh
Copy link
Collaborator

QA Passed ✅

See #7490 (comment)

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Mar 22, 2023
@westonruter westonruter mentioned this issue Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Projects
None yet
Milestone
v2.4.1
Development

Successfully merging a pull request may close this issue.

Remove React 17 requirement for AfterActivationSiteScan service ampproject/amp-wp
2 participants
@westonruter @thelovekesh