Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ability to update the status of a validation error #4045

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix ability to update the status of a validation error #4045

merged 1 commit into from
Jan 9, 2020

Conversation

westonruter
Copy link
Member

Summary

This fixes a regression I introduced in #3898, where there was no longer an ability to update the status of validation errors. Instead, the user would see this error:

Screen Shot 2020-01-08 at 17 07 43

After the changes here, the user is again able to both preview and update changes to the removed/kept status of a validation error.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v1.5 milestone Jan 9, 2020
@googlebot googlebot added the cla: yes Signed the Google CLA label Jan 9, 2020
@westonruter westonruter force-pushed the fix/validation-error-status-change-previews branch from 29f7b9a to 942063a Compare January 9, 2020 01:14
amedina
amedina approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@westonruter westonruter merged commit eba2f3b into develop Jan 9, 2020
@westonruter westonruter deleted the fix/validation-error-status-change-previews branch January 9, 2020 01:45
@csossi
Copy link

csossi commented Feb 26, 2020

Verified in QA

image

@csossi csossi added the QA passed Has passed QA and is done label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amedina amedina amedina approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA QA passed Has passed QA and is done
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@westonruter @csossi @amedina @googlebot