Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: Use latest PHPStan version to run its tests and replace deprecated autoload_files option #4879

Merged
merged 13 commits into from
Jun 17, 2020

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Jun 17, 2020

Summary

Cherry picks commits from #4738 and #4868 into the 1.5 branch. Note that an intermediary PR #4867 was already cherry-picked.

Fixes #4745
Fixes #4865

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v1.5.4 milestone Jun 17, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Has not signed the Google CLA label Jun 17, 2020
@westonruter westonruter changed the title Update/phpstan 1.5 Cherry-pick: Use latest PHPStan version to run its tests and replace deprecated autoload_files option Jun 17, 2020
@westonruter westonruter added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Jun 17, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@github-actions
Copy link
Contributor

Plugin builds for c05ea1e are ready 🛎️!

@westonruter westonruter merged commit c5603dc into 1.5 Jun 17, 2020
@westonruter westonruter deleted the update/phpstan-1.5 branch June 17, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants