Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to selected section in AMP setting page after fetching site scan urls #7051

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

dhaval-parekh
Copy link
Collaborator

@dhaval-parekh dhaval-parekh commented Apr 12, 2022

Summary

Fixes #7005

The changes in PR fix scrolling to the selected section on the "AMP setting" page on Chrome ( 100.0.4896.60 ) with a screen resolutions of 1440x900 and 1280×640.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@dhaval-parekh dhaval-parekh self-assigned this Apr 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2022

Plugin builds for 721afd1 are ready 🛎️!

@westonruter westonruter added this to the v2.3 milestone Apr 14, 2022
Copy link
Collaborator

@milindmore22 milindmore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@westonruter westonruter merged commit 5f59250 into develop Apr 18, 2022
@westonruter westonruter deleted the bug/7005-plugin-suppression-section-scroll branch April 18, 2022 17:04
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Plugin Suppression section is scrolled into view when deep linked
3 participants