Add toggle button to use native <img /> instead of <amp-img /> #7066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaval-parekh
force-pushed
the
enhancement/7035-add-toggle-for-native-img
branch
from
d3aa482
to
546dba2
Compare
westonruter
reviewed
Apr 19, 2022
|
Plugin builds for 9dd7608 are ready 🛎️!
|
Codecov Report
@@ Coverage Diff @@
## develop #7066 +/- ##
==============================================
+ Coverage 64.88% 78.23% +13.35%
- Complexity 0 6861 +6861
==============================================
Files 67 273 +206
Lines 1159 21856 +20697
==============================================
+ Hits 752 17100 +16348
- Misses 407 4756 +4349
Flags with carried forward coverage won't be shown. Click here to find out more.
|
westonruter
reviewed
Apr 20, 2022
westonruter
reviewed
Apr 20, 2022
…nt/7035-add-toggle-for-native-img * 'develop' of github.com:ampproject/amp-wp: Bump @babel/core from 7.17.10 to 7.17.12 (#7103) Bump @actions/github from 5.0.2 to 5.0.3 (#7101) Bump google/cloud-storage from 1.26.3 to 1.27.0 (#7102) Bump @babel/plugin-proposal-class-properties from 7.16.7 to 7.17.12 (#7104) Bump eslint-plugin-jest from 26.1.5 to 26.2.2 (#7105) Bump actions/setup-node from 3.1.1 to 3.2.0 (#7106) Merge pull request #7099 from ampproject/dependabot/npm_and_yarn/actions/github-5.0.2 Update Jest snapshots (npm run test:js -- --updateSnapshot) Update Gutenberg package dependencies Bump tested up to WP 6.0 Try to fix E2E test cases Update unit test case Update test cases Add 'data-amp-auto-lightbox-disable' attribute to HTML tag instead of body tag to disable auto-lightbox Merge pull request #7095 from ampproject/dependabot/npm_and_yarn/grunt-1.5.3
westonruter
approved these changes
May 18, 2022
2 tasks
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7035
This PR provide option to the users to use native
<img />instead of<amp-img />. By default it will use<amp-img />.AMP-GH-7035.mov
Checklist