Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mask-type attribute with mask-type mask element css property #7246

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Update mask-type attribute with mask-type mask element css property #7246

merged 2 commits into from
Sep 13, 2022

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Sep 7, 2022 •
edited by westonruter
Loading

Summary

This PR aims to update the mask-type attribute in <mask> elements with the mask-type CSS property.

Originally identified in #7242 where eslint-plugin-react@7.31.7 flags this attribute as unidentifiable.

Ref:

See #7242

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh self-assigned this Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Plugin builds for e062ffd are ready 🛎️!

@thelovekesh
Copy link
Collaborator Author

E2E tests are not failing locally.

image

@westonruter westonruter added this to the v2.3.1 milestone Sep 13, 2022
westonruter
westonruter approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@westonruter westonruter merged commit 3730077 into develop Sep 13, 2022
@westonruter westonruter deleted the fix/mask-type-attribute branch September 13, 2022 00:13
@westonruter westonruter modified the milestones: v2.3.1, v2.4 Jan 26, 2023
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

@thelovekesh thelovekesh

Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@thelovekesh @westonruter